Skip to content

OLS-947: Update Lightspeed customer resource content #80611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

OLS-947: Update Lightspeed customer resource content #80611

merged 1 commit into from
Aug 28, 2024

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Aug 16, 2024 •
edited
Loading

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-947

Link to docs preview:
https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-creating-the-credentials-secret-using-web-console_ols-configuring-openshift-lightspeed

https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/about/ols-about-openshift-lightspeed#ols-large-language-model-requirements

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2024 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-947 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s):

Issue: https://issues.redhat.com/browse/OLS-947

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 16, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 16, 2024 •
edited
Loading

🤖 Tue Aug 27 15:02:10 - Prow CI generated the docs preview:

https://80611--ocpdocs-pr.netlify.app/
https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/about/ols-about-openshift-lightspeed.html
https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html
https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/install/ols-installing-openshift-lightspeed.html
https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/operate/ols-using-openshift-lightspeed.html
https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/troubleshoot/ols-troubleshooting-openshift-lightspeed.html

@rh-tokeefe rh-tokeefe changed the title OLS-947: Update Lightspeed customer resource content [WIP] OLS-947: Update Lightspeed customer resource content Aug 16, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 17, 2024 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-947 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s):

Issue: https://issues.redhat.com/browse/OLS-947

Link to docs preview:
https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-creating-the-credentials-secret-using-web-console_ols-configuring-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2024 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-947 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s):

Issue: https://issues.redhat.com/browse/OLS-947

Link to docs preview:
https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-creating-the-credentials-secret-using-web-console_ols-configuring-openshift-lightspeed

https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/about/ols-about-openshift-lightspeed#ols-large-language-model-requirements

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

thoraxe
thoraxe suggested changes Aug 19, 2024
View reviewed changes
Copy link

@thoraxe thoraxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than removing the approval process doc.

JoaoFula
JoaoFula reviewed Aug 21, 2024
View reviewed changes
JoaoFula
JoaoFula reviewed Aug 21, 2024
View reviewed changes
@JoaoFula
Copy link
Contributor

LGTM

@rh-tokeefe
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 21, 2024
@abrennan89 abrennan89 self-assigned this Aug 21, 2024
@abrennan89 abrennan89 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 21, 2024
abrennan89
abrennan89 reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions and comments 🙏🏻

@abrennan89 abrennan89 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 21, 2024
@abrennan89 abrennan89 removed their assignment Aug 21, 2024
@abrennan89 abrennan89 added this to the Continuous Release milestone Aug 21, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2024
@rh-tokeefe rh-tokeefe force-pushed the OLS-947 branch 2 times, most recently from 653b55c to 7692348 Compare August 26, 2024 17:15
@rh-tokeefe rh-tokeefe force-pushed the OLS-947 branch 2 times, most recently from dd8230b to 626224f Compare August 27, 2024 14:46
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 27, 2024

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-tokeefe
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 27, 2024
@rh-tokeefe rh-tokeefe changed the title [WIP] OLS-947: Update Lightspeed customer resource content OLS-947: Update Lightspeed customer resource content Aug 27, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 27, 2024 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-947 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-947

Link to docs preview:
https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-creating-the-credentials-secret-using-web-console_ols-configuring-openshift-lightspeed

https://80611--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/about/ols-about-openshift-lightspeed#ols-large-language-model-requirements

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 27, 2024
@mburke5678
Copy link
Contributor

@rh-tokeefe LGTM. I wonder if we should send out a change management message about removing the ols-about-openshift-ai-vllm.adoc module (I am not sure who Xavier is). I understand the product is TP; but it might not be a bad idea to at least announce the change. WDYT?

@rh-tokeefe
Copy link
Contributor Author

rh-tokeefe commented Aug 28, 2024 •
edited
Loading

@mburke5678 if it's a TP product I don't think we need to. There are only a handful of customers who have installed the Lightspeed Operator. Technically the functionality exists, we just wanted to provide more testing for internal confirmation.

@mburke5678 mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 28, 2024
@mburke5678 mburke5678 merged commit 873af97 into openshift:lightspeed-docs-main Aug 28, 2024
@mburke5678
Copy link
Contributor

/cherrypick lightspeed-docs-1.0tp1

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #81013

In response to this:

/cherrypick lightspeed-docs-1.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrennan89 abrennan89 abrennan89 left review comments

+2 more reviewers

@JoaoFula JoaoFula JoaoFula left review comments

@thoraxe thoraxe thoraxe requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

8 participants

@rh-tokeefe @openshift-ci-robot @ocpdocs-previewbot @JoaoFula @mburke5678 @openshift-cherrypick-robot @thoraxe @abrennan89