Skip to content

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Aug 19, 2024

OSSM 3.0 TP1

Traces was not required for TP 1 go live, but OSSM 3.0 is still in TP1 status so this applies to TP1.

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main

Cherry pick: to https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0.0tp1

OSSM-6974 Traces content

This PR is part of the standalone doc set for the OpenShift Service Mesh project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

Version(s):

Technology Preview

OSSM 3.0 is moving to stand alone format and will not be cherry-picked back to OCP core branches.

Issue:
https://issues.redhat.com/browse/OSSM-6974

Link to docs preview:
https://80667--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/traces/ossm-distr-tracing-assembly.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 19, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 19, 2024

🤖 Thu Oct 17 15:25:49 - Prow CI generated the docs preview:

https://80667--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/traces/ossm-distr-tracing-assembly.html

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2024
@gwynnemonahan gwynnemonahan changed the title OSSM-6974 Traces content OSSM 3.0 TP1: OSSM-6974 Traces content Aug 20, 2024
@gwynnemonahan gwynnemonahan changed the title OSSM 3.0 TP1: OSSM-6974 Traces content [WIP] OSSM 3.0 TP1: OSSM-6974 Traces content Aug 22, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024
@gwynnemonahan gwynnemonahan changed the title [WIP] OSSM 3.0 TP1: OSSM-6974 Traces content [WIP] OSSM 3.0 TP1: OSSM-6974 Distributed tracing content Sep 20, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2024
@gwynnemonahan gwynnemonahan changed the title [WIP] OSSM 3.0 TP1: OSSM-6974 Distributed tracing content OSSM 3.0 TP1: OSSM-6974 Distributed tracing content Oct 1, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2024
@gwynnemonahan gwynnemonahan force-pushed the OSSM-6974 branch 2 times, most recently from c134f2a to ceef43c Compare October 3, 2024 17:14
Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the PR. as per the changes

Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check the comments.

Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update these commands.

Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...!

@gwynnemonahan gwynnemonahan force-pushed the OSSM-6974 branch 2 times, most recently from 41f66d8 to 3c0f6e9 Compare October 3, 2024 21:58
@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

99% sure there are things I've missed 😄

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 14, 2024
@gwynnemonahan
Copy link
Contributor Author

FYI Peer Reviewer: I had to update the docinfo.xml file as I just learned that attributes are not allowed.

@skrthomas skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 15, 2024
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall! Some comments for you :)

@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 16, 2024
@skrthomas skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 16, 2024
@ShaunaDiaz ShaunaDiaz added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 17, 2024
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Oct 17, 2024
@ShaunaDiaz ShaunaDiaz added the service-mesh Label for all Service Mesh PRs label Oct 17, 2024
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments prior to merge.

@ShaunaDiaz ShaunaDiaz removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 17, 2024
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 17, 2024
Copy link

openshift-ci bot commented Oct 17, 2024

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 17, 2024
@ShaunaDiaz ShaunaDiaz merged commit 1045859 into openshift:service-mesh-docs-main Oct 17, 2024
2 checks passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick service-mesh-docs-3.0.0tp1

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #83703

In response to this:

/cherrypick service-mesh-docs-3.0.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants