-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSM 3.0 TP1: OSSM-6974 Distributed tracing content #80667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM 3.0 TP1: OSSM-6974 Distributed tracing content #80667
Conversation
🤖 Thu Oct 17 15:25:49 - Prow CI generated the docs preview: |
c9a3b44
to
29aed8a
Compare
f3173e1
to
f99e375
Compare
c134f2a
to
ceef43c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update the PR. as per the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update these commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM...!
41f66d8
to
3c0f6e9
Compare
/label peer-review-needed 99% sure there are things I've missed 😄 |
FYI Peer Reviewer: I had to update the docinfo.xml file as I just learned that attributes are not allowed. |
a7c98c7
to
d9bdf11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall! Some comments for you :)
809ef5e
to
d10fe08
Compare
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments prior to merge.
34bd390
to
109eb0f
Compare
/label merge-review-needed |
e5bc1bc
to
c1995f7
Compare
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick service-mesh-docs-3.0.0tp1 |
@ShaunaDiaz: new pull request created: #83703 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
OSSM 3.0 TP1
Traces was not required for TP 1 go live, but OSSM 3.0 is still in TP1 status so this applies to TP1.
Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick: to https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0.0tp1
OSSM-6974 Traces content
This PR is part of the standalone doc set for the OpenShift Service Mesh project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.
Version(s):
Technology Preview
OSSM 3.0 is moving to stand alone format and will not be cherry-picked back to OCP core branches.
Issue:
https://issues.redhat.com/browse/OSSM-6974
Link to docs preview:
https://80667--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/traces/ossm-distr-tracing-assembly.html
QE review:
Additional information: