Skip to content

Conversation

skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Aug 22, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 22, 2024

@skrthomas: This pull request references OSDOCS-11625 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-11625
Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 22, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 22, 2024

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2024

@skrthomas: This pull request references OSDOCS-11625 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-11625
Link to docs preview:

https://80846--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/observing-network-traffic.html#network-observability-viewing-network-events_nw-observe-network-traffic
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skrthomas
Copy link
Contributor Author

@msherif1234 I have a draft of the Network policies correlation/viewing network events documentation ready for you to review.

cc @JoeAldinger for the tbd link to OVN-K feature gate docs

Comment on lines 27 to 33
spec:
sampling: 1
privileged: true
features:
- "NetworkEvents"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
spec:
sampling: 1
privileged: true
features:
- "NetworkEvents"
spec:
agent:
type: eBPF
ebpf:
privileged: true
features:
- "NetworkEvents"

Comment on lines +34 to +38
.Verification
. Navigate to the *Network Traffic* view and select the *Traffic flows* table.
. You should see the new column, *Network Events*, where you can view information about impacts that network policies, admin policies, and egress firewalls have on network flows.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add example of output messages here
cc @msherif1234

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, @jpinsonneau Do you mean an example of what's printed in the cell of the Network Events column? Or another kind of output message?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes example of informations this column can provide since it cover tons of different cases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpinsonneau awesome, thanks for the idea. I added these based on a screencapture that @msherif1234 provided of the column in the console. https://github.com/openshift/openshift-docs/pull/80846/files#diff-2c58e02f3f3d88ed7f2bea54b85dd8efb8d183028d9c8ba19f0721704f933109R39-R54

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msherif1234 do we have a full list of these ?

I only found https://github.com/ovn-org/ovn-kubernetes/pull/4596/files#diff-f3bfaffd193f40c714d0dd4f96636c614bd73cd4d1c12cbcd1ebdc31e4041e56R161 and the related tech doc https://github.com/ovn-org/ovn-kubernetes/pull/4596/files#diff-2ec9b512514bf19c87313b7da12c9436f73d963ece18048a4372b6af918124ca mentionning:

Currently, supports observability for:
- Network Policy
- (Baseline) Admin Network Policy
- Egress firewall
- UDN isolation
- Multicast ACLs

That could be added too ?

@skrthomas
Copy link
Contributor Author

OVNObservability piece #81016

Thanks @JoeAldinger

Copy link

openshift-ci bot commented Aug 29, 2024

@skrthomas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skrthomas
Copy link
Contributor Author

I'm closing this PR, as it should not be merged with the rest of the 1.7 documentation, since its now being pushed to 1.8. I will re-open the content in a no-1.8 branch.

@skrthomas skrthomas closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants