Skip to content

Conversation

skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Sep 10, 2024

Version(s):

Merge only to no-1.7. On GA 10/21/24, Sara will open a branch to integrate no-1.7 with main, and that branch will go to 4.12+.

For technical reviewers: 1.6.1 and 1.6.2 are live on docs.openshift.com but because they are on the main docs branch, they have not yet been rebased with this no-1.7 branch, so you won't see them on this preview.
Issue:

FIPS compliance: https://issues.redhat.com/browse/OSDOCS-11078
Link to docs preview:

https://81551--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/network-observability-operator-release-notes.html#network-observability-operator-1.7.0-features-enhancements_network-observability-operator-release-notes-v0
QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 10, 2024

@skrthomas skrthomas force-pushed the network-observability-1.7-release-notes branch from 65a207c to a7e517f Compare September 11, 2024 19:56
@skrthomas skrthomas force-pushed the network-observability-1.7-release-notes branch from a7e517f to 9d4d0d7 Compare October 11, 2024 18:53
@skrthomas skrthomas force-pushed the network-observability-1.7-release-notes branch 4 times, most recently from 6ce819b to 02c55dc Compare October 14, 2024 13:42

[id="network-observability-operator-tcp-flags-filtering-1-7_{context}"]
==== TCP flags filtering
You can now use the `tcpFlags` filter to control the volume of packets cached in the eBPF flow table. For more information, see xref:../../observability/network_observability/observing-network-traffic.adoc#network-observability-flowcollector-flowfilter-parameters_nw-observe-network-traffic[Flow filter configuration parameters] and xref:../../observability/network_observability/observing-network-traffic.adoc#network-observability-ebpf-flow-rule-filter_nw-observe-network-traffic[eBPF flow rule filter].
Copy link

@jotak jotak Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather say "to limit the volume of packets processed by the eBPF program", because there's more than caching, and I guess readers don't have to know about the internal details

Suggested change
You can now use the `tcpFlags` filter to control the volume of packets cached in the eBPF flow table. For more information, see xref:../../observability/network_observability/observing-network-traffic.adoc#network-observability-flowcollector-flowfilter-parameters_nw-observe-network-traffic[Flow filter configuration parameters] and xref:../../observability/network_observability/observing-network-traffic.adoc#network-observability-ebpf-flow-rule-filter_nw-observe-network-traffic[eBPF flow rule filter].
You can now use the `tcpFlags` filter to limit the volume of packets processed by the eBPF program. For more information, see xref:../../observability/network_observability/observing-network-traffic.adoc#network-observability-flowcollector-flowfilter-parameters_nw-observe-network-traffic[Flow filter configuration parameters] and xref:../../observability/network_observability/observing-network-traffic.adoc#network-observability-ebpf-flow-rule-filter_nw-observe-network-traffic[eBPF flow rule filter].

Copy link

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skrthomas the current notes LGTM
do we also specify known issues as part of RN? I pulled list using JIRA:

project=netobserv and affectedVersion = netobserv-1.7-candidate and status != closed

don't think all in that list needs a call out but some of them may, for e.g.: NETOBSERV-1933, NETOBSERV-1830 , NETOBSERV-1890

@Amoghrd
Copy link

Amoghrd commented Oct 14, 2024

LGTM

@skrthomas
Copy link
Contributor Author

@memodi thanks for calling out these known issues. We do specify known issues, but I was only aware of the bugs that were listed in the errata. I will add these known issues. Some of them don't have text, so I will follow up in the Jiras about what to write for these.

@skrthomas skrthomas force-pushed the network-observability-1.7-release-notes branch 3 times, most recently from be26d2b to 92f5b57 Compare October 16, 2024 20:51
@openshift-ci openshift-ci bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 16, 2024
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2024
include::snippets/fips-snippet.adoc[]
--

[id="network-observability-dns-enhancements-1-7_{context}]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDoc.ClosedIdQuotes: Quoted ID value is not closed.

[source,yaml]
====
kind: NetworkPolicy
apiVersion: networking.k8s.io/v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.CaseSensitiveTerms: Use 'Kubernetes' rather than 'k8s'. For more information, see RedHat.CaseSensitiveTerms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n/a since this is part of the yaml

==== DNS tracking enhancements
The following enhancements are available for DNS tracking:

* DNS tracking can work with custom port in top of the default DNS port `53`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't sound right.  Suggest:
If the DNS service maps to a different port than 53, you can specify this DNS tracking port.

@skrthomas skrthomas force-pushed the network-observability-1.7-release-notes branch 2 times, most recently from c513bc7 to 532599a Compare October 17, 2024 14:47
Copy link

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 17, 2024
@skrthomas skrthomas added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 17, 2024
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 18, 2024
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits for your consideration!

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 18, 2024
@skrthomas skrthomas force-pushed the network-observability-1.7-release-notes branch 2 times, most recently from 3605cdd to 81bd9d3 Compare October 19, 2024 20:53
@skrthomas skrthomas force-pushed the network-observability-1.7-release-notes branch from 81bd9d3 to 2ac4c95 Compare October 19, 2024 21:09
Copy link

openshift-ci bot commented Oct 19, 2024

@skrthomas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skrthomas skrthomas merged commit bf04912 into openshift:no-1.7 Oct 19, 2024
2 checks passed
@skrthomas skrthomas added this to the Continuous Release milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants