OCPBUGS-31318: Fixing xref

[rohennes]

OCPBUGS-31318: Fixing xref

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OCPBUGS-31318

Link to docs preview:
https://82326--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-low-latency-tuning.html#node-tuning-operator-assigning-proper-node-selector_cnf-master

Additional information:
Typo, no QE.

This only effects 4.13 and 4.12. This module does not exist in later versions. So I am making the fix directly in the 4.13 branch. Is this ok? And can it be backported to 4.12 or do I need a separate PR? Thanks!

[openshift-ci-robot]

@rohennes: This pull request references Jira Issue OCPBUGS-31318, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-31318 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-31318: Fixing xref

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OCPBUGS-31318

Link to docs preview:

Additional information:
Typo, no QE.

This only effects 4.13 and 4.12. This module does not exist in later versions. So I am making the fix in 4.13, can it be backported to 4.12 or do I need a separate PR?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ocpdocs-previewbot]

🤖 Wed Sep 25 13:11:24 - Prow CI generated the docs preview:

https://82326--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-low-latency-tuning.html

[openshift-ci-robot]

@rohennes: This pull request references Jira Issue OCPBUGS-31318, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-31318 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-31318: Fixing xref

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OCPBUGS-31318

Link to docs preview:
https://82326--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-low-latency-tuning.html#node-tuning-operator-assigning-proper-node-selector_cnf-master

Additional information:
Typo, no QE.

This only effects 4.13 and 4.12. This module does not exist in later versions. So I am making the fix in 4.13, can it be backported to 4.12 or do I need a separate PR?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rohennes]

/label peer-review-needed

[rohennes]

FAO: Peer reviewer, please see additional info in description, thanks!

[lpettyjo]

LGTM!

[rohennes]

/label merge-review-needed

[jeana-redhat]

These don't quite conform to guidelines, but the fixes are straightforward :)

/remove-label merge-review-in-progress
/remove-label merge-review-needed

[jeana-redhat]

Per guidelines

Suggested change

	For more information, see _Placing pods on specific nodes using node selectors_ in the _Additional resources_ section.
	For more information, see _Placing pods on specific nodes using node selectors_.

[jeana-redhat]

Better to fix the existing incorrect format here than propagate it :)

Suggested change

	* For more information about recommended firmware configuration, see xref:../scalability_and_performance/ztp_far_edge/ztp-vdu-validating-cluster-tuning.adoc#ztp-du-firmware-config-reference_vdu-config-ref[Recommended firmware configuration for vDU cluster hosts].
	* For more information about assigning a node selector, see xref:../nodes/scheduling/nodes-scheduler-node-selectors.adoc#nodes-scheduler-node-selectors[Placing pods on specific nodes using node selectors].
	* xref:../scalability_and_performance/ztp_far_edge/ztp-vdu-validating-cluster-tuning.adoc#ztp-du-firmware-config-reference_vdu-config-ref[Recommended firmware configuration for vDU cluster hosts]
	* xref:../nodes/scheduling/nodes-scheduler-node-selectors.adoc#nodes-scheduler-node-selectors[Placing pods on specific nodes using node selectors]

[rohennes]

@jeana-redhat - thanks as always, I made those changes.

/label merge-review-needed

[openshift-ci]

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[skopacz1]

Just have one question, once that's answered I can either merge as-is or wait for you to update the PR first

[openshift-ci-robot]

@rohennes: Jira Issue OCPBUGS-31318 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

OCPBUGS-31318: Fixing xref

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OCPBUGS-31318

Link to docs preview:
https://82326--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-low-latency-tuning.html#node-tuning-operator-assigning-proper-node-selector_cnf-master

Additional information:
Typo, no QE.

This only effects 4.13 and 4.12. This module does not exist in later versions. So I am making the fix directly in the 4.13 branch. Is this ok? And can it be backported to 4.12 or do I need a separate PR? Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.