Skip to content

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Sep 26, 2024

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-913

Link to docs preview:
https://82574--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-about-lightspeed-custom-resource-definition_ols-configuring-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2024

@rh-tokeefe: This pull request references OLS-913 which is a valid jira issue.

In response to this:

Version(s):

Issue: https://issues.redhat.com/browse/OLS-913

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2024

@rh-tokeefe: This pull request references OLS-913 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Version(s):

Issue: https://issues.redhat.com/browse/OLS-913

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2024

@rh-tokeefe: This pull request references OLS-913 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-913

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 26, 2024

🤖 Thu Oct 10 14:45:13 - Prow CI generated the docs preview:

https://82574--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2024

@rh-tokeefe: This pull request references OLS-913 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-913

Link to docs preview:
https://82574--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-about-lightspeed-custom-resource-definition_ols-configuring-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe rh-tokeefe changed the title OLS-913: Document the OLSConfig CRD configuration options [WIP] OLS-913: Document the OLSConfig CRD configuration options Sep 27, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2024
@rh-tokeefe
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2024
@rh-tokeefe rh-tokeefe force-pushed the OLS-913 branch 4 times, most recently from 44a7226 to 3988e63 Compare October 3, 2024 19:27
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2024
@rh-tokeefe rh-tokeefe force-pushed the OLS-913 branch 3 times, most recently from 93ec3ac to b2b5e43 Compare October 7, 2024 12:42
Copy link

@asamal4 asamal4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments related to conversation cache..
@xrajesh
I thought we only support in-memory cache now (default behaviour).
Do we even need to document redis related config infact anything under conversationCache

@rh-tokeefe rh-tokeefe force-pushed the OLS-913 branch 2 times, most recently from c6210c4 to de35ee5 Compare October 8, 2024 16:54
@xrajesh
Copy link

xrajesh commented Oct 8, 2024

Comments related to conversation cache.. @xrajesh I thought we only support in-memory cache now (default behaviour). Do we even need to document redis related config infact anything under conversationCache

We dont need to document redis related config . We can just have in_memory

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 9, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2025
@rh-tokeefe
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2025
@rh-tokeefe rh-tokeefe closed this Apr 1, 2025
@rh-tokeefe
Copy link
Contributor Author

Closing this PR. Team is exploring a way to create this content using a script.

@rh-tokeefe rh-tokeefe reopened this Apr 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025

@rh-tokeefe: This pull request references OLS-913 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-913

Link to docs preview:
https://82574--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-about-lightspeed-custom-resource-definition_ols-configuring-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rh-tokeefe rh-tokeefe closed this Apr 2, 2025
Copy link

openshift-ci bot commented Apr 2, 2025

@rh-tokeefe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-portal c476a40 link true /test validate-portal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants