Skip to content

Conversation

iblancasa
Copy link
Contributor

@iblancasa iblancasa commented Sep 30, 2024

Version(s): 4.18, 4.17, 4.16, 4.15, 4.14, 4.13, 4.12, 4.11

Issue: TRACING-4615

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: this can be added to the latest version of the documentation since it applies to the current RHOSDT version too.

Signed-off-by: Israel Blancas <iblancas@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 30, 2024

@iblancasa: This pull request references TRACING-4615 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s): 4.18, 4.17, 4.16, 4.15, 4.14, 4.13, 4.12, 4.11

Issue: TRACING-4615

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: this can be added to the latest version of the documentation since it applies to the current RHOSDT version too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 30, 2024

@iblancasa: This pull request references TRACING-4615 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s): 4.18, 4.17, 4.16, 4.15, 4.14, 4.13, 4.12, 4.11

Issue: TRACING-4615

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: this can be added to the latest version of the documentation since it applies to the current RHOSDT version too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 30, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 30, 2024


- Verify `events.enabled`: ensure that `events.enabled` is set to `true` in the configuration. If this parameter is `false`, event metrics will not be generated.
+
- Review event dimensions: make sure that the event attributes you want to track are listed under `events.dimensions`. Only the specified event attributes will be included in the event metrics.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.TermsErrors: Use 'in case', 'if', or 'when' rather than 'in the event'. For more information, see RedHat.TermsErrors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This term is correct

Signed-off-by: Israel Blancas <iblancas@redhat.com>
Copy link

openshift-ci bot commented Oct 1, 2024

@iblancasa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-portal 1b8937a link true /test validate-portal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@iblancasa iblancasa closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants