Skip to content

Conversation

sbeskin-redhat
Copy link
Contributor

Resolves: https://issues.redhat.com/browse/CNV-39963

OCP 4.17
CNV 4.17

Preview:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2024

@sbeskin-redhat: This pull request references CNV-39963 which is a valid jira issue.

In response to this:

Resolves: https://issues.redhat.com/browse/CNV-39963

OCP 4.17
CNV 4.17

Preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 9, 2024

🤖 Wed Oct 16 06:38:08 - Prow CI generated the docs preview:

https://83305--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-17-release-notes.html

@stu-gott
Copy link

LGTM

@sbeskin-redhat sbeskin-redhat force-pushed the CNV_39963_RN_CPU_Hotplug branch from 2fc9a75 to 6b482a1 Compare October 15, 2024 12:46
@sjhala-ccs sjhala-ccs added CNV Label for all CNV PRs branch/enterprise-4.17 labels Oct 15, 2024
@sjhala-ccs sjhala-ccs added this to the Continuous Release milestone Oct 15, 2024
Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjhala-ccs sjhala-ccs added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 15, 2024
@sjhala-ccs
Copy link
Contributor

@sbeskin-redhat I think you are trying to link to a module that has not been merged yet, so the build will fail. I cannot merge the PR until the build passes.

@sbeskin-redhat
Copy link
Contributor Author

sbeskin-redhat commented Oct 15, 2024

@sjhala-ccs Yes, I know. I've already asked for a peer review of that module - #83243. If you could maybe do that one first?

@sjhala-ccs
Copy link
Contributor

@sjhala-ccs Yes, I know. I've already asked for a peer review of that module - #83243. If you could maybe do that one first?

@sbeskin-redhat I am in the CNV docs meeting and Catherine suggested merging the RN PR first (without the link) because it is higher priority.

@sbeskin-redhat
Copy link
Contributor Author

@sjhala-ccs The meeting is finally over. Maybe you could take a look at the other PR?

@sbeskin-redhat sbeskin-redhat force-pushed the CNV_39963_RN_CPU_Hotplug branch from 6b482a1 to 25eb440 Compare October 15, 2024 21:56
@sbeskin-redhat sbeskin-redhat force-pushed the CNV_39963_RN_CPU_Hotplug branch from 25eb440 to 48b85f2 Compare October 16, 2024 06:10
Copy link

openshift-ci bot commented Oct 16, 2024

@sbeskin-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbeskin-redhat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 16, 2024
@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 16, 2024
@ShaunaDiaz ShaunaDiaz merged commit ec8591e into openshift:enterprise-4.17 Oct 16, 2024
2 checks passed
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants