Skip to content

Conversation

ousleyp
Copy link
Member

@ousleyp ousleyp commented Oct 9, 2024

Version(s): 4.17 only (RN)

Issue: CNV-39964

Link to docs preview: https://83311--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-17-release-notes.html#virt-4-17-infrastructure

QE review:

  • QE has approved this change.

Additional information:

@ousleyp ousleyp added CNV Label for all CNV PRs branch/enterprise-4.17 labels Oct 9, 2024
@ousleyp ousleyp added this to the Continuous Release milestone Oct 9, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2024
@ousleyp ousleyp requested review from 0xFelix and RoniKishner October 9, 2024 22:07
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 9, 2024

🤖 Thu Oct 10 16:18:50 - Prow CI generated the docs preview:

https://83311--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-17-release-notes.html

@RoniKishner
Copy link

/lgtm
looks good from QE side

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@ousleyp ousleyp added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 10, 2024
Copy link

openshift-ci bot commented Oct 10, 2024

@ousleyp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ousleyp ousleyp removed the request for review from RoniKishner October 10, 2024 16:30
@abhatt-rh abhatt-rh added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 10, 2024
Copy link
Contributor

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 10, 2024
Copy link

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
@ousleyp ousleyp merged commit b62a6a3 into openshift:enterprise-4.17 Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 CNV Label for all CNV PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants