Skip to content

Conversation

shivanisathe25
Copy link
Contributor

@shivanisathe25 shivanisathe25 commented Oct 23, 2024

Version(s):

Version for cherrypicking: build-docs-1.1

Issue:

Link to docs preview: https://84027--ocpdocs-pr.netlify.app/openshift-builds/latest/installing/installing-openshift-builds.html

QE review: @apoorvajagtap @sayan-biswas

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 23, 2024

@apoorvajagtap
Copy link
Contributor

LGTM.

@shivanisathe25
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 28, 2024
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 28, 2024
@mburke5678
Copy link
Contributor

mburke5678 commented Oct 28, 2024

@shivanisathe25 Why are these verification steps not part of the Installing Builds modules? I am not sure the verification step should be in its own module.
Also, adding the verification to the install module would remove the redundancy in the verification modules, where the introductory sentence is repeated as the verification step.

@mburke5678
Copy link
Contributor

@shivanisathe25 A few suggestions and a question.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 28, 2024
@shivanisathe25 shivanisathe25 force-pushed the RHDEVDOCS-6199 branch 3 times, most recently from caec8ce to f8f093c Compare October 29, 2024 11:28
@shivanisathe25 shivanisathe25 force-pushed the RHDEVDOCS-6199 branch 4 times, most recently from c6c13c6 to 364f680 Compare October 29, 2024 12:52
@apoorvajagtap
Copy link
Contributor

LGTM.

@shivanisathe25
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 30, 2024
@shivanisathe25
Copy link
Contributor Author

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 5, 2024
@shivanisathe25
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 5, 2024
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 5, 2024
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments and questions for your consideration. Please add the merge-review label again after addressing changes.

General comment since you are already editing the modules/ob-installing-builds-using-CLI.adoc file:

  • We don't usually use the capital letters in the file name. You can modify the file name from ob-installing-builds-using-CLI.adoc to ob-installing-builds-using-cli.adoc.
  • In the preview, I noticed that line no 9 You can also install {builds-shortname} by using the CLI may use some tiny changes such as removing "also" and expanding the abbreviation "CLI" because it's a first time occurrence in a module.
    For example: You can install {builds-shortname} by using the command-line interface (CLI).

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 5, 2024
@shivanisathe25 shivanisathe25 force-pushed the RHDEVDOCS-6199 branch 2 times, most recently from 8d2e196 to 1c37301 Compare November 6, 2024 06:31
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2024
Copy link

openshift-ci bot commented Nov 11, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Nov 11, 2024

@shivanisathe25: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shivanisathe25
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 11, 2024
@jab-rh jab-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 11, 2024
@jab-rh jab-rh merged commit 7e25657 into openshift:build-docs-main Nov 11, 2024
2 checks passed
@jab-rh
Copy link
Contributor

jab-rh commented Nov 11, 2024

/cherry-pick build-docs-1.1

@openshift-cherrypick-robot

@jab-rh: new pull request created: #84772

In response to this:

/cherry-pick build-docs-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants