-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-6199 - Builds for OpenShift: Install and Config Documentation Obsolete #84027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-6199 - Builds for OpenShift: Install and Config Documentation Obsolete #84027
Conversation
🤖 Mon Nov 11 11:29:20 - Prow CI generated the docs preview: https://84027--ocpdocs-pr.netlify.app/ |
LGTM. |
/label peer-review-needed |
@shivanisathe25 Why are these verification steps not part of the Installing Builds modules? I am not sure the verification step should be in its own module. |
@shivanisathe25 A few suggestions and a question. |
caec8ce
to
f8f093c
Compare
c6c13c6
to
364f680
Compare
LGTM. |
/label peer-review-needed |
/remove-label peer-review-needed |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments and questions for your consideration. Please add the merge-review label again after addressing changes.
General comment since you are already editing the modules/ob-installing-builds-using-CLI.adoc
file:
- We don't usually use the capital letters in the file name. You can modify the file name from
ob-installing-builds-using-CLI.adoc
toob-installing-builds-using-cli.adoc
. - In the preview, I noticed that line no 9
You can also install {builds-shortname} by using the CLI
may use some tiny changes such as removing "also" and expanding the abbreviation "CLI" because it's a first time occurrence in a module.
For example:You can install {builds-shortname} by using the command-line interface (CLI).
8d2e196
to
1c37301
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
1c37301
to
ac39236
Compare
New changes are detected. LGTM label has been removed. |
@shivanisathe25: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
/cherry-pick build-docs-1.1 |
@jab-rh: new pull request created: #84772 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
Version for cherrypicking: build-docs-1.1
Issue:
Link to docs preview: https://84027--ocpdocs-pr.netlify.app/openshift-builds/latest/installing/installing-openshift-builds.html
QE review: @apoorvajagtap @sayan-biswas
Additional information: