-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS 6265 add docinfo.xml files for builds documentation #84837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS 6265 add docinfo.xml files for builds documentation #84837
Conversation
/label peer-review-needed |
c696eb0
to
301960d
Compare
🤖 Mon Nov 25 13:44:10 - Prow CI generated the docs preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion; the text LGTM! I'm not familiar with docinfo.xml files but I trust you that they're formatted correctly to work for Pantheon. :)
about/docinfo.xml
Outdated
<productnumber>{product-version}</productnumber> | ||
<subtitle>Introduction to Builds</subtitle> | ||
<abstract> | ||
<para>This document provides an overview of Builds features. It also includes release notes and details on how to get support.</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<para>This document provides an overview of Builds features. It also includes release notes and details on how to get support.</para> | |
<para>This document provides an overview of Builds features. It also includes release notes and details about how to get support.</para> |
301960d
to
f2a7925
Compare
/label merge-review-needed |
@mramendi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick build-docs-1.0 |
/cherrypick build-docs-1.1 |
/cherrypick build-docs-1.2 |
@mburke5678: new pull request created: #85389 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mburke5678: new pull request created: #85390 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mburke5678: new pull request created: #85391 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
build-docs-1.0 , build-docs-1.1 , build-docs-1.2
Issue:
RHDEVDOCS 6265
Link to docs preview:
N/A
QE review:
N/A
Additional information:
This is a technical PR that adds files necessary for Pantheon builds; the files were previously in Gitlab. Doc text as such is not affected, but the snippets in the files are visible in docs so they should be peer-reviewed.