Skip to content

Conversation

mramendi
Copy link
Contributor

Version(s):

build-docs-1.0 , build-docs-1.1 , build-docs-1.2

Issue:

RHDEVDOCS 6265

Link to docs preview:

N/A

QE review:
N/A

Additional information:

This is a technical PR that adds files necessary for Pantheon builds; the files were previously in Gitlab. Doc text as such is not affected, but the snippets in the files are visible in docs so they should be peer-reviewed.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 12, 2024
@mramendi
Copy link
Contributor Author

@mramendi
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 12, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 12, 2024

🤖 Mon Nov 25 13:44:10 - Prow CI generated the docs preview:

https://84837--ocpdocs-pr.netlify.app/

@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 13, 2024
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion; the text LGTM! I'm not familiar with docinfo.xml files but I trust you that they're formatted correctly to work for Pantheon. :)

<productnumber>{product-version}</productnumber>
<subtitle>Introduction to Builds</subtitle>
<abstract>
<para>This document provides an overview of Builds features. It also includes release notes and details on how to get support.</para>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<para>This document provides an overview of Builds features. It also includes release notes and details on how to get support.</para>
<para>This document provides an overview of Builds features. It also includes release notes and details about how to get support.</para>

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 13, 2024
@mramendi
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 25, 2024
Copy link

openshift-ci bot commented Nov 25, 2024

@mramendi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 25, 2024
@mburke5678 mburke5678 merged commit 53642e3 into openshift:build-docs-main Nov 25, 2024
2 checks passed
@mburke5678
Copy link
Contributor

/cherrypick build-docs-1.0

@mburke5678
Copy link
Contributor

/cherrypick build-docs-1.1

@mburke5678
Copy link
Contributor

/cherrypick build-docs-1.2

@openshift-cherrypick-robot

@mburke5678: new pull request created: #85389

In response to this:

/cherrypick build-docs-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #85390

In response to this:

/cherrypick build-docs-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #85391

In response to this:

/cherrypick build-docs-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants