Skip to content

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Nov 18, 2024

Note: CM WILL BE SENT AFTER SME ACK.

Note: In error I used the engineering Jira number to represent the feature branch name. This number will not interfere with engineering PRs. OCPBUGS-44672 is the correct docs Jira for this issue.

Version(s):
4.17

Issue:
OCPBUGS-44672

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 18, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-43714, which is invalid:

  • expected Jira Issue OCPBUGS-43714 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2024
@dfitzmau dfitzmau changed the title OCPBUGS-43714: Added IPsec enabled node known issue to RNs]# OCPBUGS#43714: Added IPsec enabled node known issue to RNs]# Nov 18, 2024
@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Nov 18, 2024
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
4.17

Issue:
OCPBUGS-43714

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 18, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 18, 2024

🤖 Mon Nov 18 16:34:31 - Prow CI generated the docs preview:

https://85047--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-17-release-notes.html

@dfitzmau dfitzmau changed the title OCPBUGS#43714: Added IPsec enabled node known issue to RNs]# OCPBUGS#43714: Added IPsec enabled node known issue to RNs Nov 18, 2024
Copy link

openshift-ci bot commented Nov 18, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zshi-redhat
Copy link
Contributor

LGTM

@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 20, 2024
@eohartman
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 20, 2024
@eohartman
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 20, 2024
@dfitzmau dfitzmau changed the title OCPBUGS#43714: Added IPsec enabled node known issue to RNs OCPBUGS#43714: 4.17 Added IPsec enabled node known issue to RNs Nov 20, 2024
@dfitzmau dfitzmau removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 21, 2024
Copy link

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@huiran0826
Copy link

/lgtm

@dfitzmau dfitzmau merged commit 886e850 into openshift:enterprise-4.17 Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.17 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants