Skip to content

RHDEVDOCS-6270: Release notes PR for GitOps 1.14.2 z-stream release #85102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

RHDEVDOCS-6270: Release notes PR for GitOps 1.14.2 z-stream release #85102

merged 1 commit into from
Nov 25, 2024

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Nov 19, 2024 •
edited
Loading

Version(s):

GitOps 1.14

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6270

Link to docs preview:

Release Notes for Red Hat OpenShift GitOps 1.14.2

QE review:

  • QE has approved this change.

SME review: @ishitasequeira @keithchong
Peer review: @skrthomas
QE review: @varshab1210

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6270 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.14

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6270

Link to docs preview:

QE review:

  • QE has approved this change.

SME review:
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 19, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 19, 2024 •
edited
Loading

🤖 Fri Nov 22 05:59:59 - Prow CI generated the docs preview:

https://85102--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes-1-14.html

ishitasequeira
ishitasequeira reviewed Nov 19, 2024
View reviewed changes
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6270 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.14

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6270

Link to docs preview:

QE review:

  • QE has approved this change.

SME review: @ishitasequeira @keithchong
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6270 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.14

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6270

Link to docs preview:

Release Notes for Red Hat OpenShift GitOps 1.14.2

QE review:

  • QE has approved this change.

SME review: @ishitasequeira @keithchong
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@keithchong
Copy link

@Dhruv-Soni11 , the 1.14.2 RN entry for 5788 looks good.

"Before this update, the New App panel behaved unexpectedly as it reopened immediately after being closed, and typing in fields causes the cursor and text to flash repeatedly. With this fix, the New App panel operates as intended. GITOPS-5788"

One question I have is whether to reference 5788 or 5671? There were duplicates opened in Jira.

@Dhruv-Soni11
Copy link
Contributor Author

@Dhruv-Soni11 , the 1.14.2 RN entry for 5788 looks good.

"Before this update, the New App panel behaved unexpectedly as it reopened immediately after being closed, and typing in fields causes the cursor and text to flash repeatedly. With this fix, the New App panel operates as intended. GITOPS-5788"

One question I have is whether to reference 5788 or 5671? There were duplicates opened in Jira.

@keithchong - I don't know the answer to this question so I request @ishitasequeira to help us regarding this.

ishitasequeira
ishitasequeira reviewed Nov 19, 2024
View reviewed changes
varshab1210
varshab1210 reviewed Nov 20, 2024
View reviewed changes
@ishitasequeira
Copy link

ishitasequeira commented Nov 20, 2024 •
edited by openshift-ci bot
Loading

GITOPS-5788

As we marked https://issues.redhat.com/browse/GITOPS-5788 as a dupe. Please refer https://issues.redhat.com/browse/GITOPS-5671

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6270 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.14

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6270

Link to docs preview:

Release Notes for Red Hat OpenShift GitOps 1.14.2

QE review:

  • QE has approved this change.

SME review: @ishitasequeira @keithchong
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6270 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.14

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6270

Link to docs preview:

Release Notes for Red Hat OpenShift GitOps 1.14.2

QE review:

  • QE has approved this change.

SME review: @ishitasequeira @keithchong
Peer review:
QE review: @varshab1210

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Dhruv-Soni11
Copy link
Contributor Author

/retest

1 similar comment
@Dhruv-Soni11
Copy link
Contributor Author

/retest

@varshab1210
Copy link

LGTM, thanks

ishitasequeira
ishitasequeira approved these changes Nov 21, 2024
View reviewed changes
Copy link

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skrthomas
skrthomas reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@skrthomas skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 21, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@Dhruv-Soni11
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 21, 2024
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 21, 2024
bergerhoffer
bergerhoffer reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has 2 commits, which need to be squashed before it can be merged.

Also, can you please fix the one other comment while you're doing that? Thanks!

@bergerhoffer bergerhoffer removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 21, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 22, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6270 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.14

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6270

Link to docs preview:

Release Notes for Red Hat OpenShift GitOps 1.14.2

QE review:

  • QE has approved this change.

SME review: @ishitasequeira @keithchong
Peer review: @skrthomas
QE review: @varshab1210

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2024 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6270 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.14

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6270

Link to docs preview:

Release Notes for Red Hat OpenShift GitOps 1.14.2

QE review:

  • QE has approved this change.

SME review: @ishitasequeira @keithchong
Peer review: @skrthomas
QE review: @varshab1210

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 22, 2024

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Dhruv-Soni11
Copy link
Contributor Author

Hi @bergerhoffer I have incorporated the feedback for your comment and squashed the extra commit. PTAL and merge the PR if everything looks fine.

@Dhruv-Soni11
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 25, 2024
@Srivaralakshmi Srivaralakshmi added merge-review-in-progress Signifies that the merge review team is reviewing this PR lgtm Indicates that a PR is ready to be merged. gitops and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 25, 2024
@Srivaralakshmi Srivaralakshmi added this to the Continuous Release milestone Nov 25, 2024
@Srivaralakshmi Srivaralakshmi merged commit 3206555 into openshift:gitops-docs-1.14 Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@skrthomas skrthomas skrthomas left review comments

+2 more reviewers

@varshab1210 varshab1210 varshab1210 left review comments

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@skrthomas skrthomas

Labels
gitops jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@Dhruv-Soni11 @openshift-ci-robot @ocpdocs-previewbot @keithchong @ishitasequeira @varshab1210 @bergerhoffer @skrthomas @Srivaralakshmi