RHDEVDOCS-6206: Builds for OpenShift: Disconnected Install Instructions #85106

shivanisathe25 · 2024-11-19T06:57:14Z

Version(s) to cherry-pick: build-docs-1.2

Issue: https://issues.redhat.com/browse/RHDEVDOCS-6206

Link to docs preview: https://85106--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/using-builds.html

SME review: @apoorvajagtap

QE review:

QE has approved this change.

Additional information:

ocpdocs-previewbot · 2024-11-19T07:17:10Z

🤖 Tue Nov 26 13:07:52 - Prow CI generated the docs preview:

https://85106--ocpdocs-pr.netlify.app/openshift-builds/latest/installing/installing-openshift-builds.html
https://85106--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/using-builds.html

openshift-ci-robot · 2024-11-19T08:56:14Z

@shivanisathe25: This pull request references RHDEVDOCS-6206 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-11-19T08:57:00Z

@shivanisathe25: This pull request references RHDEVDOCS-6206 which is a valid jira issue.

In response to this:

Version(s) to cherry-pick: build-docs-1.1

Issue:

Link to docs preview: https://85106--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/using-builds.html

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

shivanisathe25 · 2024-11-21T05:10:39Z

/label retest

openshift-ci · 2024-11-21T05:10:42Z

@shivanisathe25: The label(s) /label retest cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

shivanisathe25 · 2024-11-21T05:12:55Z

/retest

openshift-ci-robot · 2024-11-21T06:35:00Z

@shivanisathe25: This pull request references RHDEVDOCS-6206 which is a valid jira issue.

In response to this:

Version(s) to cherry-pick: build-docs-1.1

Issue:

Link to docs preview: https://85106--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/using-builds.html

SME review: @apoorvajagtap

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

avinal

Few changes.

modules/ob-enabling-builds-in-a-network-restricted-environment-using-the-buildah-build.adoc

.../ob-enabling-builds-in-a-network-restricted-environment-using-the-source-to-image-build.adoc

avinal

Looks good to me

shivanisathe25 · 2024-11-22T12:49:51Z

/label peer-review-needed

modules/ob-enabling-builds-in-a-network-restricted-environment-using-the-buildah-build.adoc

skrthomas

Some comments for you. Lookin' good :)

modules/ob-enabling-builds-in-a-network-restricted-environment-using-the-buildah-build.adoc

.../ob-enabling-builds-in-a-network-restricted-environment-using-the-source-to-image-build.adoc

work_with_builds/using-builds.adoc

shivanisathe25 · 2024-11-25T10:26:51Z

/label merge-review-needed

opayne1 · 2024-11-25T13:49:58Z

Hi @shivanisathe25 please squash your commits and then resubmit for merge review. Thank you!

openshift-ci-robot · 2024-11-26T10:53:06Z

@shivanisathe25: This pull request references RHDEVDOCS-6206 which is a valid jira issue.

In response to this:

Version(s) to cherry-pick: build-docs-1.2

Issue:

Link to docs preview: https://85106--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/using-builds.html

SME review: @apoorvajagtap

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

shivanisathe25 · 2024-11-26T11:32:49Z

/label merge-review-needed

openshift-ci-robot · 2024-11-26T11:54:02Z

@shivanisathe25: This pull request references RHDEVDOCS-6206 which is a valid jira issue.

In response to this:

Version(s) to cherry-pick: build-docs-1.2

Issue: https://issues.redhat.com/browse/RHDEVDOCS-6206

Link to docs preview: https://85106--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/using-builds.html

SME review: @apoorvajagtap

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

xenolinux

General comment: Please consider giving files short names. it's best to keep the id and the filename same.

One suggestion about not using xref in a module.

Holding merge for now. Ensure to add the merge-review label again after addressing comments.

.../ob-enabling-builds-in-a-network-restricted-environment-using-the-source-to-image-build.adoc

modules/ob-enabling-builds-in-a-network-restricted-environment-using-the-buildah-build.adoc

.../ob-enabling-builds-in-a-network-restricted-environment-using-the-source-to-image-build.adoc

RHDEVDOCS-6207 Some minor updates

openshift-ci · 2024-11-26T13:09:32Z

@shivanisathe25: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

shivanisathe25 · 2024-11-26T14:03:54Z

/label merge-review-needed

mburke5678 · 2024-11-26T18:00:54Z

modules/ob-creating-buildah-build-in-a-network-restricted-environment.adoc

+
+:_mod-docs-content-type: PROCEDURE
+[id='ob-creating-buildah-build-in-a-network-restricted-environment_{context}']
+= Creating buildah build in a network restricted environment


Should this be restricted network? I see network restricted environment is used elsewhere in the Builds docs.
If network restricted environment and restricted network are not the same thing, we should at least go with network-restricted environment.
Can be done in a separate PR. Not worth holding up the merge.

mburke5678 · 2024-11-26T18:02:51Z

/cherrypick build-docs-1.2

openshift-cherrypick-robot · 2024-11-26T18:03:39Z

@mburke5678: new pull request created: #85505

In response to this:

/cherrypick build-docs-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 19, 2024

shivanisathe25 force-pushed the network-restricted-env branch from 75e8a74 to 3628079 Compare November 19, 2024 08:46

shivanisathe25 changed the title ~~Network restricted env~~ RHDEVDOCS-6206: Builds for OpenShift: Disconnected Install Instructions Nov 19, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 19, 2024

shivanisathe25 force-pushed the network-restricted-env branch from 3628079 to ea4e4e6 Compare November 19, 2024 09:17

avinal suggested changes Nov 22, 2024

View reviewed changes

shivanisathe25 force-pushed the network-restricted-env branch from 56944d3 to 62c78d2 Compare November 22, 2024 09:53

avinal approved these changes Nov 22, 2024

View reviewed changes

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 22, 2024

skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 22, 2024

skrthomas reviewed Nov 22, 2024

View reviewed changes

modules/ob-enabling-builds-in-a-network-restricted-environment-using-the-buildah-build.adoc Outdated Show resolved Hide resolved

skrthomas reviewed Nov 22, 2024

View reviewed changes

skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 22, 2024

shivanisathe25 force-pushed the network-restricted-env branch 2 times, most recently from a02a5cf to 7e72262 Compare November 25, 2024 06:38

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 25, 2024

opayne1 removed the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 25, 2024

shivanisathe25 force-pushed the network-restricted-env branch from 7e72262 to 42803df Compare November 26, 2024 11:17

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2024

shivanisathe25 force-pushed the network-restricted-env branch from 42803df to ed70f6f Compare November 26, 2024 11:31

openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 26, 2024

xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 26, 2024

xenolinux reviewed Nov 26, 2024

View reviewed changes

.../ob-enabling-builds-in-a-network-restricted-environment-using-the-source-to-image-build.adoc Outdated Show resolved Hide resolved

xenolinux reviewed Nov 26, 2024

View reviewed changes

modules/ob-enabling-builds-in-a-network-restricted-environment-using-the-buildah-build.adoc Show resolved Hide resolved

xenolinux reviewed Nov 26, 2024

View reviewed changes

.../ob-enabling-builds-in-a-network-restricted-environment-using-the-source-to-image-build.adoc Show resolved Hide resolved

xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 26, 2024

shivanisathe25 force-pushed the network-restricted-env branch 2 times, most recently from 562444e to 953c685 Compare November 26, 2024 12:37

Updated content

c1f77ba

RHDEVDOCS-6207 Some minor updates

shivanisathe25 force-pushed the network-restricted-env branch from 953c685 to c1f77ba Compare November 26, 2024 12:39

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 26, 2024

mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 26, 2024

mburke5678 reviewed Nov 26, 2024

View reviewed changes

mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 26, 2024

mburke5678 merged commit be8a257 into openshift:build-docs-main Nov 26, 2024
2 checks passed

openshift-cherrypick-robot mentioned this pull request Nov 26, 2024

[build-docs-1.2] RHDEVDOCS-6206: Builds for OpenShift: Disconnected Install Instructions #85505

Merged

RHDEVDOCS-6206: Builds for OpenShift: Disconnected Install Instructions #85106

RHDEVDOCS-6206: Builds for OpenShift: Disconnected Install Instructions #85106

Uh oh!

Conversation

shivanisathe25 commented Nov 19, 2024 • edited by xenolinux Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 19, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 19, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shivanisathe25 commented Nov 21, 2024

Uh oh!

openshift-ci bot commented Nov 21, 2024

Uh oh!

shivanisathe25 commented Nov 21, 2024

Uh oh!

openshift-ci-robot commented Nov 21, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avinal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avinal left a comment

Choose a reason for hiding this comment

Uh oh!

shivanisathe25 commented Nov 22, 2024

Uh oh!

Uh oh!

skrthomas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shivanisathe25 commented Nov 25, 2024

Uh oh!

opayne1 commented Nov 25, 2024

Uh oh!

openshift-ci-robot commented Nov 26, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shivanisathe25 commented Nov 26, 2024

Uh oh!

openshift-ci-robot commented Nov 26, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xenolinux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci bot commented Nov 26, 2024

Uh oh!

shivanisathe25 commented Nov 26, 2024

Uh oh!

mburke5678 Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mburke5678 commented Nov 26, 2024

Uh oh!

openshift-cherrypick-robot commented Nov 26, 2024

shivanisathe25 commented Nov 19, 2024 •

edited by xenolinux

Loading

ocpdocs-previewbot commented Nov 19, 2024 •

edited

Loading

openshift-ci-robot commented Nov 19, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 19, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 21, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 26, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 26, 2024 •

edited by openshift-ci bot

Loading