Skip to content

OBSDOCS-1499 - Logging 5.8.15 RN - OCP 4.12 thru 4.15 #85216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

OBSDOCS-1499 - Logging 5.8.15 RN - OCP 4.12 thru 4.15 #85216

wants to merge 1 commit into from

Conversation

libander
Copy link
Contributor

@libander libander commented Nov 20, 2024 •
edited by openshift-ci bot
Loading

Version(s): 4.12, 4.13, 4.14, 4.15

Issue: OBSDOCS-1499

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@libander
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-needed Signifies that the peer review team needs to review this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2024
@libander
Copy link
Contributor Author

@anpingli - Review please.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 20, 2024 •
edited
Loading

🤖 Wed Nov 20 21:45:52 - Prow CI generated the docs preview:

https://85216--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging_release_notes/logging-5-8-release-notes.html

anpingli
anpingli reviewed Nov 20, 2024
View reviewed changes
Copy link

@anpingli anpingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aspauldi
Copy link

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 20, 2024
aspauldi
aspauldi reviewed Nov 20, 2024
View reviewed changes
aspauldi
aspauldi reviewed Nov 20, 2024
View reviewed changes
Copy link

@aspauldi aspauldi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Libby, I noticed just a couple of things.

@aspauldi
Copy link

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 20, 2024
@libander
Copy link
Contributor Author

Release still pending.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 20, 2024

@libander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@libander
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 21, 2024
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@bergerhoffer bergerhoffer added this to the Continuous Release milestone Nov 21, 2024
@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 21, 2024
bergerhoffer
bergerhoffer reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@libander The advisory links are 404ing. Can you check and see if the release hasn't gone live yet, or if the links are wrong or something?

@bergerhoffer bergerhoffer removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 21, 2024
@libander
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 22, 2024
@libander
Copy link
Contributor Author

Shipped live, should be good to merge. Thanks again @bergerhoffer ! :)

@bmcelvee bmcelvee added merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Nov 22, 2024
@adellape adellape self-assigned this Nov 22, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 22, 2024
@adellape
Copy link
Contributor

Holding for #85216 (comment)

@adellape
Copy link
Contributor

Dropping from merge queue til the broken link is updated. Can re-queue for next week's merge-review squad.

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 22, 2024
@gabriel-rh gabriel-rh mentioned this pull request Nov 25, 2024
Merged
@gabriel-rh
Copy link
Contributor

closing this on in favour of #85216

@gabriel-rh gabriel-rh closed this Nov 26, 2024
@xperimental xperimental mentioned this pull request Dec 16, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@bmcelvee bmcelvee bmcelvee left review comments

+4 more reviewers

@xperimental xperimental xperimental approved these changes

@adellape adellape adellape left review comments

@anpingli anpingli anpingli left review comments

@aspauldi aspauldi aspauldi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adellape adellape

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

9 participants

@libander @ocpdocs-previewbot @aspauldi @bergerhoffer @adellape @gabriel-rh @xperimental @anpingli @bmcelvee