Skip to content

Conversation

sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Nov 25, 2024

Version(s):
4.18

Issue:
TELCODOCS-2091

Link to docs preview:

  • Storage (New features and enhancements)

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2024
@ocpdocs-previewbot
Copy link

🤖 Mon Nov 25 07:34:51 - Prow CI generated the docs preview:

https://85368--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-18-release-notes.html

Copy link

openshift-ci bot commented Nov 25, 2024

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sr1kar99
Copy link
Contributor Author

@qJkee
Could you please review this PR?
Thanks!

@qJkee
Copy link

qJkee commented Nov 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@sr1kar99
Copy link
Contributor Author

@radeore
Could you please review this PR?
Thanks!

@radeore
Copy link

radeore commented Nov 27, 2024

@mmakwana30 Could you take a look?

@sr1kar99
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 16, 2024
@snarayan-redhat snarayan-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 16, 2024
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Left couple of comments.

Reminder to get QE approval before merging!

@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 16, 2024
@mmakwana30
Copy link

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants