Skip to content

OCPBUGS#44659-13: Added important note for disabling IPsec for 4.13 a… #85581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

OCPBUGS#44659-13: Added important note for disabling IPsec for 4.13 a… #85581

merged 1 commit into from
Dec 10, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Nov 28, 2024 •
edited
Loading

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • SME has approved this change (Periyasamy Palanisamy).
  • QE has approved this change (Anurag Saxena).

Links:

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 28, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-44659, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-44659 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…nd 4.12

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 28, 2024
@dfitzmau dfitzmau changed the title OCPBUGS-44659-13: Added important note for disabling IPsec for 4.13 a… OCPBUGS#44659-13: Added important note for disabling IPsec for 4.13 a… Nov 28, 2024
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key 44659-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • [] SME has approved this change (Periyasamy Palanisamy).
  • [] QE has approved this change (Anurag Saxena).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Nov 28, 2024
@openshift-ci-robot
Copy link

@dfitzmau: The referenced Jira(s) [44659-13] could not be located, all automatically applied jira labels will be removed.

In response to this:

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • [] SME has approved this change (Periyasamy Palanisamy).
  • [] QE has approved this change (Anurag Saxena).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 28, 2024
@dfitzmau dfitzmau added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. branch/enterprise-4.12 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. branch/enterprise-4.13 labels Nov 28, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 28, 2024 •
edited
Loading

🤖 Mon Dec 09 17:49:48 - Prow CI generated the docs preview:

https://85581--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ovn_kubernetes_network_provider/configuring-ipsec-ovn.html

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2024
@dfitzmau dfitzmau force-pushed the OCPBUGS-44659-13 branch 2 times, most recently from 1282b04 to c448ed0 Compare November 29, 2024 16:59
@pperiyasamy
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 5, 2024
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key 44659-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • SME has approved this change (Periyasamy Palanisamy).
  • [] QE has approved this change (Anurag Saxena).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 5, 2024
@openshift-ci-robot
Copy link

@dfitzmau: The referenced Jira(s) [44659-13] could not be located, all automatically applied jira labels will be removed.

Retaining the jira/valid-reference label as it was manually added.

In response to this:

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • SME has approved this change (Periyasamy Palanisamy).
  • [] QE has approved this change (Anurag Saxena).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key 44659-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • SME has approved this change (Periyasamy Palanisamy).
  • [] QE has approved this change (Anurag Saxena).

4.14 update: #85485

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@dfitzmau:

Retaining the jira/valid-reference label as it was manually added.

In response to this:

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • SME has approved this change (Periyasamy Palanisamy).
  • [] QE has approved this change (Anurag Saxena).

4.14 update: #85485

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key 44659-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • SME has approved this change (Periyasamy Palanisamy).
  • [] QE has approved this change (Anurag Saxena).

Links:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anuragthehatter
Copy link

/lgtm

@openshift-ci-robot
Copy link

@dfitzmau:

Retaining the jira/valid-reference label as it was manually added.

In response to this:

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • SME has approved this change (Periyasamy Palanisamy).
  • [] QE has approved this change (Anurag Saxena).

Links:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue with key 44659-13 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • SME has approved this change (Periyasamy Palanisamy).
  • QE has approved this change (Anurag Saxena).

Links:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@dfitzmau:

Retaining the jira/valid-reference label as it was manually added.

In response to this:

Version(s):
4.13 and 4.12

Issue:
OCPBUGS-44659

Link to docs preview:
Disabling IPsec encryption

  • SME has approved this change (Periyasamy Palanisamy).
  • QE has approved this change (Anurag Saxena).

Links:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pperiyasamy
Copy link
Member

/hold
need to add a statement about ovn-ipsec daemonset deletion as in a corner case it won't be removed at first attempt itself.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 9, 2024

New changes are detected. LGTM label has been removed.

@dfitzmau dfitzmau force-pushed the OCPBUGS-44659-13 branch 4 times, most recently from a2572b9 to 7e41337 Compare December 9, 2024 14:43
pperiyasamy
pperiyasamy reviewed Dec 9, 2024
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 9, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pperiyasamy
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@dfitzmau dfitzmau merged commit 6ef8005 into openshift:enterprise-4.13 Dec 10, 2024
2 checks passed
@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #86017

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeana-redhat jeana-redhat jeana-redhat approved these changes

+1 more reviewer

@pperiyasamy pperiyasamy pperiyasamy left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@pperiyasamy pperiyasamy

@anuragthehatter anuragthehatter

Labels
branch/enterprise-4.12 branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @pperiyasamy @anuragthehatter @openshift-cherrypick-robot @jeana-redhat