Skip to content

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Dec 2, 2024

OSSM 3.0 TP1

12/02/2024: Per PM, no TP2 branch. It merges into serivce-mesh-docs-main and service-mesh-docs-3.0.0tp1. There is no TP 2 page.

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main

Cherry pick to https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the OpenShift Service Mesh project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

Version(s):

Technology Preview.

OSSM 3.0 is moving to stand alone format and will not be cherry-picked back to OCP core branches.

Issue:
https://issues.redhat.com/browse/OSSM-8474

Link to docs preview: https://85681--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/ossm-release-notes/ossm-release-notes-assembly.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 2, 2024

@gwynnemonahan gwynnemonahan force-pushed the OSSM-8474 branch 3 times, most recently from b47685f to d987654 Compare December 9, 2024 14:14
@gwynnemonahan
Copy link
Contributor Author

Rebased 12/09/2024 in the AM.

@dgn
Copy link

dgn commented Dec 9, 2024

I don't see a page for TP2? We'll need to mention that Power and Z are not available, again (for TP1 they are now)

@gwynnemonahan
Copy link
Contributor Author

@dgn ,

Jamie did not want the prod doc team to cut a new branch for TP2 so there is no TP2 page. Only TP1.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2024
@gwynnemonahan
Copy link
Contributor Author

IBM Power and IBM Z have been added as unsupported features in TP2.

@gwynnemonahan gwynnemonahan force-pushed the OSSM-8474 branch 2 times, most recently from f6b7c31 to 9383aca Compare December 9, 2024 18:16
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2024
@gwynnemonahan gwynnemonahan force-pushed the OSSM-8474 branch 2 times, most recently from 6b5ccf7 to 45bcc12 Compare December 10, 2024 13:52
Copy link

@FilipB FilipB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.

@gwynnemonahan gwynnemonahan force-pushed the OSSM-8474 branch 3 times, most recently from f1a252c to 376bd9c Compare December 11, 2024 14:03
@gwynnemonahan
Copy link
Contributor Author

@FilipB Changes made.

@FilipB
Copy link

FilipB commented Dec 11, 2024

Can we also please add one known issue and a note about Kiali 2.1 operator?
Known issue:
When installing Red Hat OpenShift Service Mesh 3.0 Technology Preview 2 on a cluster with Red Hat OpenShift Service Mesh 3.0 Technology Preview 1, the operator is not upgraded automatically. It is necessary to uninstall TP1 version of the operator.
Note:
New 2.1 Kiali operator is available in the new candidates channel.

@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Dec 11, 2024

Can we also please add one known issue and a note about Kiali 2.1 operator? Known issue: When installing Red Hat OpenShift Service Mesh 3.0 Technology Preview 2 on a cluster with Red Hat OpenShift Service Mesh 3.0 Technology Preview 1, the operator is not upgraded automatically. It is necessary to uninstall TP1 version of the operator. Note: New 2.1 Kiali operator is available in the new candidates channel.

OK. I need a Jira to link to for this. Please create one, and do the following:

  • Check the "Release Notes" box.
  • Fill in the "Release notes text" field using the following format:

State the issue.
If there is a workaround, include the workaround.
If there is no workaround, state: Currently, no workaround exists for this issue.
See https://docs.openshift.com/container-platform/4.15/service_mesh/v2x/servicemesh-release-notes.html#ossm-rn-known-issues-ossm_ossm-release-notes for examples.

  • Tag me in a comment so I know and can review.

@FilipB
Copy link

FilipB commented Dec 11, 2024

Known issue Jira: https://issues.redhat.com/browse/OSSM-8597

For the kiali note, we just need: "New 2.1 Kiali operator is available in the new candidates channel."

Copy link

@FilipB FilipB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@gwynnemonahan
Copy link
Contributor Author

Rebased 12/12/2024 in the AM

@gwynnemonahan
Copy link
Contributor Author

Per Filip via Slack, the automatic update of the operator Known Issue has been resolved and can be removed from rel notes.

The Known Issue has been removed.

Copy link

@FilipB FilipB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@gwynnemonahan
Copy link
Contributor Author

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 12, 2024
Copy link

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link

@FilipB FilipB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

Resubmitting after number last minute changes from engineering.

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 12, 2024
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 13, 2024
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a few nits to align with IBM Style.

Copy link

openshift-ci bot commented Dec 13, 2024

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 13, 2024
@lahinson lahinson added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 13, 2024
@lahinson
Copy link
Contributor

/lgtm for merge review

@lahinson lahinson merged commit 98065f0 into openshift:service-mesh-docs-main Dec 13, 2024
2 checks passed
@lahinson
Copy link
Contributor

/cherrypick service-mesh-docs-3.0.0tp1

@openshift-cherrypick-robot

@lahinson: new pull request created: #86284

In response to this:

/cherrypick service-mesh-docs-3.0.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants