Skip to content

MIG-1673: Release notes for MTC 1.7.18 #86689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MIG-1673: Release notes for MTC 1.7.18 #86689

wants to merge 1 commit into from

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Jan 3, 2025 •
edited
Loading

JIRA

Version(s):

  • OCP 4.14,
  • OCP 4.15,
  • OCP 4.16

Link to docs preview:

QE review:

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2025 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1673 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 3, 2025 •
edited
Loading

🤖 Thu Jan 16 22:51:41 - Prow CI generated the docs preview:

https://86689--ocpdocs-pr.netlify.app/openshift-enterprise/latest/migration_toolkit_for_containers/release_notes/mtc-release-notes-1-7.html

rayfordj
rayfordj approved these changes Jan 14, 2025
View reviewed changes
Copy link

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@rayfordj
Copy link

/unassign

@midays
Copy link

midays commented Jan 14, 2025

LGTM

@anarnold97 anarnold97 changed the title WIP - MIG-1673: Release notes for MTC 1.7.18 MIG-1673: Release notes for MTC 1.7.18 Jan 16, 2025
@anarnold97
Copy link
Contributor Author

/label mtc

@openshift-ci openshift-ci bot added MTC Label for all MTC PRs and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 16, 2025
@anarnold97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 16, 2025
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 16, 2025
@lpettyjo lpettyjo self-requested a review January 16, 2025 16:06
lpettyjo
lpettyjo reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

modules/migration-mtc-release-notes-1-7-18.adoc Outdated
[id="migration-mtc-release-notes-1-7-18_{context}"]
= {mtc-full} 1.7.18 release notes

{mtc-first} 1.7.18 is a Container Grade Only (CGO) release, released to refresh the health grades of the containers, with no changes to any code in the product itself compared to that of {mtc-short} 1.7.17.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a run-on sentence.

Rewrite as: "{mtc-first} 1.7.18 is a Container Grade Only (CGO) release, which is released to refresh the health grades of the containers, with no changes to any code in the product itself compared to that of {mtc-short} 1.7.17."

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 16, 2025
anarnold97
anarnold97 commented Jan 16, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 16, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2025 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1673 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

Version(s):

  • OCP 4.14,
  • OCP 4.15,
  • OCP 4.16

Link to docs preview:

QE review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97 anarnold97 force-pushed the MIG-1673-Release-notes-MTC-1.7.18 branch from 45d4d3f to 6b0f310 Compare January 16, 2025 18:03
@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@ShaunaDiaz
Copy link
Contributor

Hey @anarnold97 any PR against the main branch also has to go into the 4.18 branch, but you have marked this as 4.16 and back. Could you clarify where this content needs to go?

@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 16, 2025
ShaunaDiaz
ShaunaDiaz reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify whether this can go in the enterprise-4.18 branch.

@anarnold97
Copy link
Contributor Author

Please clarify whether this can go in the enterprise-4.18 branch.

image

Same versions as in the opening comments

anarnold97
anarnold97 commented Jan 16, 2025
View reviewed changes
@anarnold97
WIP - MIG-1673: Release notes for MTC 1.7.18
8a0583e 
Signed-off-by: A.Arnold <anarnold@redhat.com>
@anarnold97 anarnold97 force-pushed the MIG-1673-Release-notes-MTC-1.7.18 branch from 6c71419 to 8a0583e Compare January 16, 2025 22:39
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 16, 2025

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This was referenced Jan 16, 2025
Merged
Merged
Merged
@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 16, 2025
@anarnold97
Copy link
Contributor Author

To be merged for 4.14, 4.15, and 4.16

image

As you are going to say you cannot cherry pick, please see following cherry picks:

Thanks

@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 17, 2025
xenolinux
xenolinux reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge review LGTM

@xenolinux
Copy link
Contributor

@anarnold97 Noted that you have confirmed, this change goes to 4.14, 4.15, and 4.16 only. Since you have now created 3 manual PRs from enterprise branches with this existing un-merged PR from main, I will close this PR, and merge your versioned PRs.

FYI for such future instances: If the update does not go continuously to the latest release (4.18 in this case), consider creating separate PRs from enterprise branches, to avoid confusion.

@xenolinux
Copy link
Contributor

PRs created from 4.14, 4.15, and 4.16 have been merged.

@xenolinux
Copy link
Contributor

Closing this pull request in favor of #86689 (comment)

@xenolinux xenolinux closed this Jan 17, 2025
@anarnold97
Copy link
Contributor Author

@xenolinux - thanks for getting this. Just did not want to mess us all around

@anarnold97 anarnold97 mentioned this pull request May 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

@lpettyjo lpettyjo lpettyjo left review comments

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

+2 more reviewers

@rayfordj rayfordj rayfordj approved these changes

@midays midays midays approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. MTC Label for all MTC PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@anarnold97 @openshift-ci-robot @ocpdocs-previewbot @rayfordj @midays @ShaunaDiaz @xenolinux @lpettyjo