-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OLS-1354: List ability to attach a YAML file to a question in the release notes #87180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rh-tokeefe: This pull request references OLS-1354 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: This pull request references OLS-1354 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: This pull request references OLS-1354 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
@rh-tokeefe: This pull request references OLS-1354 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm cancel |
/lgtm |
New changes are detected. LGTM label has been removed. |
LGTM |
@rh-tokeefe: This pull request references OLS-1354 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise LGTM!
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment, otherwise LGTM
modules/ols-0-2-1-release-notes.adoc
Outdated
* With this release, the {ols-long} User Interface displays an email link that can be used to contact the {ols-official} Development Team. | ||
* With this release, the {ols-long} User Interface displays an email link that can be used to contact the {ols-official} Development Team. | ||
|
||
* This release introduces the ability to attach a YAML file to a question you ask on any page accessible from *Storage*, *Compute* or, *Builds* in the {ocp-product-title} web console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* This release introduces the ability to attach a YAML file to a question you ask on any page accessible from *Storage*, *Compute* or, *Builds* in the {ocp-product-title} web console. | |
* This release introduces the ability to attach a YAML file to a question you ask on any page accessible from *Storage*, *Compute*, or *Builds* in the {ocp-product-title} web console. |
Looks like the comma is misplaced by mistake. Once done, PR is ready for merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh dear lord, i quickly made this edit while on a meeting call and clearly introduced waste while doing so.
thanks for catching it and for merging the PR @xenolinux!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem :)
@rh-tokeefe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Merging now |
/cherrypick lightspeed-docs-1.0tp1 |
@xenolinux: new pull request created: #87221 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Affects:
lightspeed-main
lightspeed-docs-1.0tp1
This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.
PR must be CP'd back to the tp1 branch.
Based on discussion with Kathryn, the CM process is not necessary for this content update to TP release notes that were previously published.
Version(s): Tech Preview
Issue: https://issues.redhat.com/browse/OLS-1354
Link to docs preview: https://87180--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/release_notes/ols-release-notes.html#ols-0-2-1-release-notes_ols-release-notes
QE review:
Additional information: