Skip to content

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Jan 16, 2025

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Based on discussion with Kathryn, the CM process is not necessary for this content update to TP release notes that were previously published.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-1354

Link to docs preview: https://87180--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/release_notes/ols-release-notes.html#ols-0-2-1-release-notes_ols-release-notes

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2025

@rh-tokeefe: This pull request references OLS-1354 which is a valid jira issue.

In response to this:

…notes

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-1354

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2025

@rh-tokeefe: This pull request references OLS-1354 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-1354

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2025

@rh-tokeefe: This pull request references OLS-1354 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-1354

Link to docs preview: https://87180--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/release_notes/ols-release-notes.html#ols-0-2-1-release-notes_ols-release-notes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyoto
Copy link
Member

kyoto commented Jan 17, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025

@rh-tokeefe: This pull request references OLS-1354 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Based on discussion with Kathryn, the CM process is not necessary for this content update to TP release notes that were previously published.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-1354

Link to docs preview: https://87180--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/release_notes/ols-release-notes.html#ols-0-2-1-release-notes_ols-release-notes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyoto
Copy link
Member

kyoto commented Jan 17, 2025

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@kyoto
Copy link
Member

kyoto commented Jan 17, 2025

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 17, 2025
Copy link

openshift-ci bot commented Jan 17, 2025

New changes are detected. LGTM label has been removed.

@JoaoFula
Copy link
Contributor

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025

@rh-tokeefe: This pull request references OLS-1354 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Based on discussion with Kathryn, the CM process is not necessary for this content update to TP release notes that were previously published.

Version(s): Tech Preview

Issue: https://issues.redhat.com/browse/OLS-1354

Link to docs preview: https://87180--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/release_notes/ols-release-notes.html#ols-0-2-1-release-notes_ols-release-notes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 17, 2025
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 17, 2025
@skopacz1 skopacz1 added this to the Continuous Release milestone Jan 17, 2025
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM!

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 17, 2025
@rh-tokeefe
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 17, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 17, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, otherwise LGTM

* With this release, the {ols-long} User Interface displays an email link that can be used to contact the {ols-official} Development Team.
* With this release, the {ols-long} User Interface displays an email link that can be used to contact the {ols-official} Development Team.

* This release introduces the ability to attach a YAML file to a question you ask on any page accessible from *Storage*, *Compute* or, *Builds* in the {ocp-product-title} web console.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This release introduces the ability to attach a YAML file to a question you ask on any page accessible from *Storage*, *Compute* or, *Builds* in the {ocp-product-title} web console.
* This release introduces the ability to attach a YAML file to a question you ask on any page accessible from *Storage*, *Compute*, or *Builds* in the {ocp-product-title} web console.

Looks like the comma is misplaced by mistake. Once done, PR is ready for merge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh dear lord, i quickly made this edit while on a meeting call and clearly introduced waste while doing so.

thanks for catching it and for merging the PR @xenolinux!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem :)

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 17, 2025
Copy link

openshift-ci bot commented Jan 17, 2025

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux
Copy link
Contributor

Merging now

@xenolinux xenolinux merged commit 69805bd into openshift:lightspeed-docs-main Jan 17, 2025
2 checks passed
@xenolinux
Copy link
Contributor

/cherrypick lightspeed-docs-1.0tp1

@openshift-cherrypick-robot

@xenolinux: new pull request created: #87221

In response to this:

/cherrypick lightspeed-docs-1.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants