Skip to content

OCPBUGS-18537: (Release note) ingressClassName is required for all ingress objects #87421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

OCPBUGS-18537: (Release note) ingressClassName is required for all ingress objects #87421

merged 1 commit into from
Feb 4, 2025

Conversation

DCChadwick
Copy link

@DCChadwick DCChadwick commented Jan 22, 2025 •
edited
Loading

…ingress objects

Version(s): 4.12

Issue: OCPBUGS-18537

Link to docs preview: https://87421--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html#ingressClassName-required_release-notes

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 22, 2025
@openshift-ci-robot
Copy link

@DCChadwick: This pull request references Jira Issue OCPBUGS-18537, which is invalid:

  • expected Jira Issue OCPBUGS-18537 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…ingress objects

Version(s): 4.12

Issue: OCPBUGS-18537

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 22, 2025 •
edited
Loading

🤖 Thu Jan 23 15:06:24 - Prow CI generated the docs preview:

https://87421--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html

@DCChadwick
Copy link
Author

SME review complete

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 22, 2025
@DCChadwick
Copy link
Author

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 22, 2025
@DCChadwick
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 22, 2025
@maxwelldb maxwelldb added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 22, 2025
@maxwelldb maxwelldb self-requested a review January 22, 2025 21:37
@maxwelldb maxwelldb added this to the Continuous Release milestone Jan 22, 2025
maxwelldb
maxwelldb reviewed Jan 22, 2025
View reviewed changes
@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 22, 2025
@openshift-ci-robot
Copy link

@DCChadwick: This pull request references Jira Issue OCPBUGS-18537, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
  • expected Jira Issue OCPBUGS-18537 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

…ingress objects

Version(s): 4.12

Issue: OCPBUGS-18537

Link to docs preview: https://87421--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html#ingressClassName-required_release-notes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 23, 2025

@DCChadwick: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@melvinjoseph86
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 23, 2025
@DCChadwick
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 23, 2025
@DCChadwick
Copy link
Author

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 23, 2025
@DCChadwick
Copy link
Author

label merge-review-needed

@DCChadwick
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 28, 2025
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 28, 2025
@bergerhoffer
Copy link
Contributor

@DCChadwick Did you check with @kalexand-rh or anyone on whether this required change management? Usually updating older versions of release notes does.

@bergerhoffer
Copy link
Contributor

Removing the merge-* labels for now until ^ question gets answered.

@bergerhoffer bergerhoffer added branch/enterprise-4.12 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 28, 2025
@ahardin-rh
Copy link
Contributor

LGTM! Acking from the strategy side for change management. Thanks!

@DCChadwick
Copy link
Author

LGTM received from Product Experience via Slack

@kalexand-rh
Copy link
Contributor

LGTM

1 similar comment
@mcurry-rh
Copy link

LGTM

@Miciah
Copy link
Contributor

Miciah commented Feb 3, 2025

Would it make sense to fold this into the existing release note under https://docs.openshift.com/container-platform/4.12/release_notes/ocp-4-12-release-notes.html#ocp-4-12-networking-bug-fixes_release-notes?

  • Previously, a cluster that was upgraded from a version of OpenShift Container Platform earlier than 4.8 could have orphaned Route objects. This was caused by earlier versions of OpenShift Container Platform translating Ingress objects into Route objects irrespective of a given Ingress object’s indicated IngressClass. With this update, an alert is sent to the cluster administrator about any orphaned Route objects still present in the cluster after Ingress-to-Route translation. This update also adds another alert that notifies the cluster administrator about any Ingress objects that do not specify an IngressClass. (BZ#1962502)

Otherwise, LGTM.

@DCChadwick
Copy link
Author

DCChadwick commented Feb 4, 2025 •
edited
Loading

Hi, @Miciah! Thanks for your review. I don't think we should move this rn to that location because it's not really describing a bug fix but a change in behavior.

@DCChadwick
Copy link
Author

All ACKs and LGTMs received from stakeholders. Sending for merge review.

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 4, 2025
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 4, 2025
@mburke5678 mburke5678 merged commit 6ddfa42 into openshift:enterprise-4.12 Feb 4, 2025
2 checks passed
@openshift-ci-robot
Copy link

@DCChadwick: Jira Issue OCPBUGS-18537 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

…ingress objects

Version(s): 4.12

Issue: OCPBUGS-18537

Link to docs preview: https://87421--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html#ingressClassName-required_release-notes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mburke5678 mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwelldb maxwelldb maxwelldb left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.