Skip to content

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Jan 23, 2025

Version: none for cherry-picking, monitoring-docs-restructure only
QE review:

  • QE has approved this change.

Docs preview:

Additional information:
The changes in the PR are not yet user-facing

This PR moves content from old assebly to the new ones. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

You can see the original assembly here: Common monitoring configuration scenarios

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2025

@eromanova97: This pull request references OBSDOCS-1603 which is a valid jira issue.

In response to this:

Version: none for cherry-picking, monitoring-docs-restructure only
QE review:

  • QE has approved this change.

Docs preview:

Additional information:
The changes in the PR are not yet user-facing

This PR moves content from old assebly to the new ones. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 23, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 23, 2025

🤖 Fri Jan 24 09:48:33 - Prow CI generated the docs preview:
https://87498--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2025

@eromanova97: This pull request references OBSDOCS-1603 which is a valid jira issue.

In response to this:

Version: none for cherry-picking, monitoring-docs-restructure only
QE review:

  • QE has approved this change.

Docs preview:

Additional information:
The changes in the PR are not yet user-facing

This PR moves content from old assebly to the new ones. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@juzhao
Copy link

juzhao commented Jan 23, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2025

@eromanova97: This pull request references OBSDOCS-1603 which is a valid jira issue.

In response to this:

Version: none for cherry-picking, monitoring-docs-restructure only
QE review:

  • QE has approved this change.

Docs preview:

Additional information:
The changes in the PR are not yet user-facing

This PR moves content from old assebly to the new ones. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2025

@eromanova97: This pull request references OBSDOCS-1603 which is a valid jira issue.

In response to this:

Version: none for cherry-picking, monitoring-docs-restructure only
QE review:

  • QE has approved this change.

Docs preview:

You can see the original assembly here: Common monitoring configuration scenarios

Additional information:
The changes in the PR are not yet user-facing

This PR moves content from old assebly to the new ones. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2025

@eromanova97: This pull request references OBSDOCS-1603 which is a valid jira issue.

In response to this:

Version: none for cherry-picking, monitoring-docs-restructure only
QE review:

  • QE has approved this change.

Docs preview:

Additional information:
The changes in the PR are not yet user-facing

This PR moves content from old assebly to the new ones. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

You can see the original assembly here: Common monitoring configuration scenarios

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 23, 2025
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I checked the structure and links, and I left a couple of minor suggestions for your consideration.

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 23, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
Copy link

openshift-ci bot commented Jan 24, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Jan 24, 2025

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 24, 2025
@jab-rh jab-rh merged commit 7ac0feb into openshift:monitoring-docs-restructure Jan 24, 2025
2 checks passed
@jab-rh jab-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 24, 2025
@eromanova97 eromanova97 deleted the OBSDOCS-1603 branch January 27, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants