-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-1603: Add assemblies to the 'Getting started' section #87498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-1603: Add assemblies to the 'Getting started' section #87498
Conversation
@eromanova97: This pull request references OBSDOCS-1603 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
d0e8a46
to
d9915da
Compare
🤖 Fri Jan 24 09:48:33 - Prow CI generated the docs preview: |
@eromanova97: This pull request references OBSDOCS-1603 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
observability/monitoring/getting-started/developer-and-non-administrator-steps.adoc
Show resolved
Hide resolved
/lgtm |
@eromanova97: This pull request references OBSDOCS-1603 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-needed |
@eromanova97: This pull request references OBSDOCS-1603 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1603 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I checked the structure and links, and I left a couple of minor suggestions for your consideration.
observability/monitoring/getting-started/core-platform-monitoring-first-steps.adoc
Show resolved
Hide resolved
observability/monitoring/getting-started/core-platform-monitoring-first-steps.adoc
Outdated
Show resolved
Hide resolved
observability/monitoring/getting-started/user-workload-monitoring-first-steps.adoc
Outdated
Show resolved
Hide resolved
observability/monitoring/getting-started/user-workload-monitoring-first-steps.adoc
Show resolved
Hide resolved
observability/monitoring/getting-started/developer-and-non-administrator-steps.adoc
Outdated
Show resolved
Hide resolved
d9915da
to
f88ccd6
Compare
New changes are detected. LGTM label has been removed. |
f88ccd6
to
cbc5b8c
Compare
@eromanova97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
7ac0feb
into
openshift:monitoring-docs-restructure
Version: none for cherry-picking,
monitoring-docs-restructure
onlyQE review:
Docs preview:
Additional information:
The changes in the PR are not yet user-facing
This PR moves content from old assebly to the new ones. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.
You can see the original assembly here: Common monitoring configuration scenarios
Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.