-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS#43809: Clarifying what's created for each service account #87965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bergerhoffer: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label peer-review-needed |
/remove-label peer-review-needed /label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added just very small considerations, otherwise looks good to me!
However, please wait for the review of @dfitzmau and the peer-review-done
label as I am new to peer review squad.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Excellent work @eromanova97 . LGTM. |
@wangke19 can you please QE review? |
lgtm |
/cherrypick enterprise-4.18 |
/cherrypick enterprise-4.17 |
/cherrypick enterprise-4.16 |
@bergerhoffer: new pull request created: #88200 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bergerhoffer: new pull request created: #88201 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bergerhoffer: new pull request created: #88202 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.16+
Issue:
https://issues.redhat.com/browse/OCPBUGS-43809
Link to docs preview:
QE review:
Additional information: