Skip to content

Conversation

brendan-daly-red-hat
Copy link
Contributor

@brendan-daly-red-hat brendan-daly-red-hat commented Feb 5, 2025

Version:
4.18

Issue:
https://issues.redhat.com/browse/OSDOCS-12856

Link to docs preview:
Installing a cluster on Google Cloud Platform using the C4 and C4A machine series

QE review:

  • QE has approved this change.

Additional information:
This is the original PR for this release note: #87667. As Ben is on paternity leave, I created a new PR to apply review comments and publish the PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 5, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 5, 2025

🤖 Thu Feb 06 14:06:34 - Prow CI generated the docs preview:

https://88059--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-18-release-notes.html


With this release, you can deploy a cluster on {gcp-short} using the C4 and C4A machine series for compute or control plane machines. The supported disk type of these machines is `hyperdisk-balanced`. If you use an instance type that requires Hyperdisk storage, all of the nodes in your cluster must support Hyperdisk storage, and you must change the default storage class to use Hyperdisk storage.

For more information about configuring machine types, see xref:../installing/installing_gcp/installation-config-parameters-gcp.adoc#installation-configuration-parameters-gcp[Installation configuration parameters for GCP].

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about also linking to the Google documents on C4 machine series and C4A machine series?

@brendan-daly-red-hat brendan-daly-red-hat force-pushed the OSDOCS-12856-RN_2 branch 2 times, most recently from 1c84a7d to 3c3f3fc Compare February 6, 2025 11:43
@brendan-daly-red-hat
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 6, 2025
@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.18 labels Feb 6, 2025
@mburke5678 mburke5678 added this to the Planned for 4.18 GA milestone Feb 6, 2025

With this release, you can deploy a cluster on {gcp-short} using the C4 and C4A machine series for compute or control plane machines. The supported disk type of these machines is `hyperdisk-balanced`. If you use an instance type that requires Hyperdisk storage, all of the nodes in your cluster must support Hyperdisk storage, and you must change the default storage class to use Hyperdisk storage.

For more information about configuring machine types, see xref:../installing/installing_gcp/installation-config-parameters-gcp.adoc#installation-configuration-parameters-gcp[Installation configuration parameters for GCP], link:https://cloud.google.com/compute/docs/general-purpose-machines#c4_series[C4 machine series], and link:https://cloud.google.com/compute/docs/general-purpose-machines#c4a_series[C4A machine series].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc guidelines: When pointing to a link that exists external to Red Hat’s customer portal documentation, add the link attribute, and use the <document_heading_name> (<document_source>)

Suggested change
For more information about configuring machine types, see xref:../installing/installing_gcp/installation-config-parameters-gcp.adoc#installation-configuration-parameters-gcp[Installation configuration parameters for GCP], link:https://cloud.google.com/compute/docs/general-purpose-machines#c4_series[C4 machine series], and link:https://cloud.google.com/compute/docs/general-purpose-machines#c4a_series[C4A machine series].
For more information about configuring machine types, see xref:../installing/installing_gcp/installation-config-parameters-gcp.adoc#installation-configuration-parameters-gcp[Installation configuration parameters for GCP], link:https://cloud.google.com/compute/docs/general-purpose-machines#c4_series[C4 machine series] (Compute Engine docs), and link:https://cloud.google.com/compute/docs/general-purpose-machines#c4a_series[C4A machine series] (Compute Engine docs).

@mburke5678
Copy link
Contributor

@brendan-daly-red-hat One suggestion. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 6, 2025
Copy link

openshift-ci bot commented Feb 6, 2025

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@brendan-daly-red-hat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 6, 2025
@jldohmann jldohmann added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 6, 2025
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jldohmann jldohmann merged commit d140ebc into openshift:enterprise-4.18 Feb 6, 2025
2 checks passed
@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants