Skip to content

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Feb 5, 2025

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1
service-mesh-docs-3.0

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 and 3.0 branches.

Version(s): TP, 3.0

Issue: https://issues.redhat.com/browse/OSSM-5365

Link to docs preview: https://88108--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/uninstalling/ossm-uninstalling-openshift-service-mesh.html#uninstalling-service-mesh-operator-control-plane-web-console_ossm-uninstalling-openshift-service-mesh

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025

@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025

@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue.

In response to this:

Version(s): TP

Issue: https://issues.redhat.com/browse/OSSM-5365

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025

@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1
service-mesh-docs-3.0

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 branch.

Version(s): TP, 3.0

Issue: https://issues.redhat.com/browse/OSSM-5365

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025

@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1
service-mesh-docs-3.0

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 and 3.0 branches.

Version(s): TP, 3.0

Issue: https://issues.redhat.com/browse/OSSM-5365

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe rh-tokeefe changed the base branch from service-mesh-docs-3.0 to service-mesh-docs-main February 5, 2025 19:11
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025

@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1
service-mesh-docs-3.0

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 and 3.0 branches.

Version(s): TP, 3.0

Issue: https://issues.redhat.com/browse/OSSM-5365

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 5, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2025

@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1
service-mesh-docs-3.0

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 and 3.0 branches.

Version(s): TP, 3.0

Issue: https://issues.redhat.com/browse/OSSM-5365

Link to docs preview: https://88108--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/uninstalling/ossm-uninstalling-openshift-service-mesh.html#uninstalling-service-mesh-operator-control-plane-web-console_ossm-uninstalling-openshift-service-mesh

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..!

@rh-tokeefe
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2025

@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1
service-mesh-docs-3.0

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 and 3.0 branches.

Version(s): TP, 3.0

Issue: https://issues.redhat.com/browse/OSSM-5365

Link to docs preview: https://88108--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/uninstalling/ossm-uninstalling-openshift-service-mesh.html#uninstalling-service-mesh-operator-control-plane-web-console_ossm-uninstalling-openshift-service-mesh

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DCChadwick
Copy link

/assign @DCChadwick
/review @DCChadwick
/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 6, 2025
Copy link

@DCChadwick DCChadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion. Otherwise, this looks good to me.
/LGTM

@DCChadwick
Copy link

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR lgtm Indicates that a PR is ready to be merged. and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR lgtm Indicates that a PR is ready to be merged. labels Feb 6, 2025
Copy link

openshift-ci bot commented Feb 6, 2025

New changes are detected. LGTM label has been removed.

@rh-tokeefe rh-tokeefe changed the title OSSM-5356: Delete CRDs when deleting the operator OSSM-5365: Delete CRDs when deleting the operator Feb 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2025

@rh-tokeefe: This pull request references OSSM-5365 which is a valid jira issue.

In response to this:

Affects:

service-mesh-docs-main
service-mesh-docs-3.0.0tp1
service-mesh-docs-3.0

This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the tp1 and 3.0 branches.

Version(s): TP, 3.0

Issue: https://issues.redhat.com/browse/OSSM-5365

Link to docs preview: https://88108--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/uninstalling/ossm-uninstalling-openshift-service-mesh.html#uninstalling-service-mesh-operator-control-plane-web-console_ossm-uninstalling-openshift-service-mesh

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Feb 6, 2025

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-tokeefe
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 6, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 6, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux merged commit b01441a into openshift:service-mesh-docs-main Feb 6, 2025
2 checks passed
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 6, 2025
@xenolinux
Copy link
Contributor

/cherrypick service-mesh-docs-3.0.0tp1

@xenolinux
Copy link
Contributor

/cherrypick service-mesh-docs-3.0

@openshift-cherrypick-robot

@xenolinux: new pull request created: #88186

In response to this:

/cherrypick service-mesh-docs-3.0.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@xenolinux: new pull request created: #88187

In response to this:

/cherrypick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants