-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSM-5365: Delete CRDs when deleting the operator #88108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-5365: Delete CRDs when deleting the operator #88108
Conversation
@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Thu Feb 06 18:05:30 - Prow CI generated the docs preview: |
@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM..!
/label peer-review-needed |
@rh-tokeefe: This pull request references OSSM-5356 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/assign @DCChadwick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion. Otherwise, this looks good to me.
/LGTM
modules/ossm-uninstalling-service-mesh-operator-control-plane-web-console.adoc
Outdated
Show resolved
Hide resolved
/remove-label peer-review-in-progress |
New changes are detected. LGTM label has been removed. |
@rh-tokeefe: This pull request references OSSM-5365 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherrypick service-mesh-docs-3.0.0tp1 |
/cherrypick service-mesh-docs-3.0 |
@xenolinux: new pull request created: #88186 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@xenolinux: new pull request created: #88187 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Affects:
service-mesh-docs-main
service-mesh-docs-3.0.0tp1
service-mesh-docs-3.0
This PR is part of the standalone doc set for the Service Mesh 3.0 project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.
PR must be CP'd back to the tp1 and 3.0 branches.
Version(s): TP, 3.0
Issue: https://issues.redhat.com/browse/OSSM-5365
Link to docs preview: https://88108--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/uninstalling/ossm-uninstalling-openshift-service-mesh.html#uninstalling-service-mesh-operator-control-plane-web-console_ossm-uninstalling-openshift-service-mesh
QE review:
Additional information: