Skip to content

OSSM-8699: [DOC] Add warning to installation documentation about potential conflicts with 2.6 #88216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

OSSM-8699: [DOC] Add warning to installation documentation about potential conflicts with 2.6 #88216

merged 1 commit into from
Feb 11, 2025

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Feb 7, 2025 •
edited
Loading

Change type: Doc update; Add warning to installation documentation about potential conflicts with 2.6

Doc JIRA: https://issues.redhat.com/browse/OSSM-8699

Fix Version: service-mesh-docs-main and service-mesh-docs-3.0

Doc Preview: https://88216--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html

SME Review: @sridhargaddam
QE Review: @FilipB
Peer Review: @xenolinux

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025 •
edited by openshift-ci bot
Loading

@shreyasiddhartha: This pull request references OSSM-8699 which is a valid jira issue.

In response to this:

Change type: Doc update; Add warning to installation documentation about potential conflicts with 2.6

Doc JIRA: https://issues.redhat.com/browse/OSSM-8699

Fix Version: service-mesh-docs-main and service-mesh-docs-3.0

Doc Preview:

SME Review
QE Review:
Peer Review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 7, 2025 •
edited
Loading

🤖 Tue Feb 11 13:34:49 - Prow CI generated the docs preview:

https://88216--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025 •
edited by openshift-ci bot
Loading

@shreyasiddhartha: This pull request references OSSM-8699 which is a valid jira issue.

In response to this:

Change type: Doc update; Add warning to installation documentation about potential conflicts with 2.6

Doc JIRA: https://issues.redhat.com/browse/OSSM-8699

Fix Version: service-mesh-docs-main and service-mesh-docs-3.0

Doc Preview: https://88216--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html

SME Review
QE Review:
Peer Review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@shreyasiddhartha: This pull request references OSSM-8699 which is a valid jira issue.

In response to this:

Change type: Doc update; Add warning to installation documentation about potential conflicts with 2.6

Doc JIRA: https://issues.redhat.com/browse/OSSM-8699

Fix Version: service-mesh-docs-main and service-mesh-docs-3.0

Doc Preview: https://88216--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html

SME Review
QE Review: @FilipB
Peer Review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 11, 2025 •
edited by openshift-ci bot
Loading

@shreyasiddhartha: This pull request references OSSM-8699 which is a valid jira issue.

In response to this:

Change type: Doc update; Add warning to installation documentation about potential conflicts with 2.6

Doc JIRA: https://issues.redhat.com/browse/OSSM-8699

Fix Version: service-mesh-docs-main and service-mesh-docs-3.0

Doc Preview: https://88216--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html

SME Review: @sridhargaddam
QE Review: @FilipB
Peer Review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@shreyasiddhartha
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 11, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 11, 2025
xenolinux
xenolinux reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a change; otherwise LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 11, 2025 •
edited by openshift-ci bot
Loading

@shreyasiddhartha: This pull request references OSSM-8699 which is a valid jira issue.

In response to this:

Change type: Doc update; Add warning to installation documentation about potential conflicts with 2.6

Doc JIRA: https://issues.redhat.com/browse/OSSM-8699

Fix Version: service-mesh-docs-main and service-mesh-docs-3.0

Doc Preview: https://88216--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-installing-openshift-service-mesh.html

SME Review: @sridhargaddam
QE Review: @FilipB
Peer Review: @xenolinux

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 11, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 11, 2025
@skopacz1 skopacz1 added merge-review-in-progress Signifies that the merge review team is reviewing this PR service-mesh Label for all Service Mesh PRs labels Feb 11, 2025
@skopacz1 skopacz1 added this to the Continuous Release milestone Feb 11, 2025
skopacz1
skopacz1 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM!

@skopacz1 skopacz1 merged commit 6334680 into openshift:service-mesh-docs-main Feb 11, 2025
2 checks passed
@skopacz1
Copy link
Contributor

/cherrypick service-mesh-docs-3.0

@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #88375

In response to this:

/cherrypick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 11, 2025
Merged
@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

@skopacz1 skopacz1 skopacz1 approved these changes

+2 more reviewers

@FilipB FilipB FilipB approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

8 participants

@shreyasiddhartha @openshift-ci-robot @ocpdocs-previewbot @skopacz1 @openshift-cherrypick-robot @FilipB @sridhargaddam @xenolinux