Skip to content

OSSM-5632: Installing the istioctl tool & Supported Commands #88326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

OSSM-5632: Installing the istioctl tool & Supported Commands #88326

merged 1 commit into from
Feb 27, 2025

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Feb 10, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-5632 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-5632 which is a valid jira issue.

In response to this:

Version(s):

Issue: https://issues.redhat.com/browse/OSSM-5632

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe rh-tokeefe changed the title OSSM-5632: Installing the istioctl tool & Supported Commands [WIP] OSSM-5632: Installing the istioctl tool & Supported Commands Feb 10, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 10, 2025 •
edited
Loading

🤖 Wed Feb 26 20:53:42 - Prow CI generated the docs preview:

https://88326--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-istioctl-tool.html
https://88326--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/checklists/ossm-migrating-read-me-assembly.html

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-5632 which is a valid jira issue.

In response to this:

Version(s):

Issue: https://issues.redhat.com/browse/OSSM-5632

Link to docs preview:
https://88326--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-istioctl-tool.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2025
@bmangoen
Copy link
Member

@rh-tokeefe Maybe we should add in a note the direct link to all available istioctl versions

@rh-tokeefe
Copy link
Contributor Author

@bmangoen generally speaking we are encouraged to refrain from creating external links as much as possible. Do you think we can achieve the same result using a note that does not include a link?

@bmangoen
Copy link
Member

@bmangoen generally speaking we are encouraged to refrain from creating external links as much as possible. Do you think we can achieve the same result using a note that does not include a link?

I understand that it is not a great way to use links but I'm not sure we can make it without it.
Actually, other teams do use links for their cli download purpose.

@rh-tokeefe
Copy link
Contributor Author

Excellent, @bmangoen, thank you for providing a reference to a published document for a product doing something similar.

@pbajjuri20
Copy link

I have not seen Istioctl download link in the OCP 4.17 version cluster.

Screenshot From 2025-02-17 13-32-33

@rh-tokeefe
Copy link
Contributor Author

rh-tokeefe commented Feb 17, 2025 •
edited
Loading

@pbajjuri20 do you think it should be listed there is we also provide the link in the Service Mesh docs?

Presently the OSSM 3.0 product and doc is still Tech Preview. Maybe after the product GAs we can ask to have the OCP topic updated?

@pbajjuri20
Copy link

I'm able to see the Istioctl and downloaded successfully.

pbajjuri20
pbajjuri20 suggested changes Feb 17, 2025
View reviewed changes
bmangoen
bmangoen reviewed Feb 18, 2025
View reviewed changes
pbajjuri20
pbajjuri20 approved these changes Feb 24, 2025
View reviewed changes
Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...!

@bmangoen
Copy link
Member

LGTM

@rh-tokeefe
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 24, 2025
longmuir
longmuir reviewed Feb 24, 2025
View reviewed changes
_topic_maps/_topic_map.yml Outdated
File: ossm-multi-cluster-topologies
- Name: Deploying multiple service meshes on a single cluster
File: ossm-deploying-multiple-service-meshes-on-single-cluster
- Name: Istioctl
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we consider a more descriptive title that's similar to the others, like "Installing Istio's command-line utility: Istioctl" or just "Installing Istio's command-line utility"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 24, 2025
jeana-redhat
jeana-redhat reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor format/consistency things :)

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-5632 which is a valid jira issue.

In response to this:

Version(s):

Issue: https://issues.redhat.com/browse/OSSM-5632

Link to docs preview:
https://88326--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-istioctl-tool.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 26, 2025

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-5632 which is a valid jira issue.

In response to this:

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

Version(s): Technology Preview

Issue: https://issues.redhat.com/browse/OSSM-5632

Link to docs preview:
https://88326--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-istioctl-tool.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 26, 2025
@rh-tokeefe rh-tokeefe changed the title [WIP] OSSM-5632: Installing the istioctl tool & Supported Commands OSSM-5632: Installing the istioctl tool & Supported Commands Feb 26, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 27, 2025
xenolinux
xenolinux reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux merged commit f296aa4 into openshift:service-mesh-docs-main Feb 27, 2025
2 checks passed
@xenolinux
Copy link
Contributor

/cherrypick service-mesh-docs-3.0

@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #89306

In response to this:

/cherrypick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 27, 2025
Merged
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

@jeana-redhat jeana-redhat jeana-redhat left review comments

+3 more reviewers

@longmuir longmuir longmuir left review comments

@bmangoen bmangoen bmangoen approved these changes

@pbajjuri20 pbajjuri20 pbajjuri20 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@rh-tokeefe @openshift-ci-robot @ocpdocs-previewbot @bmangoen @pbajjuri20 @xenolinux @openshift-cherrypick-robot @longmuir @jeana-redhat @openshift-merge-robot