Skip to content

Conversation

jmagak
Copy link

@jmagak jmagak commented Feb 13, 2025

OBSDOCS-1652: Logging 6.1.2 Release Notes

Version(s): 4.15, 4.16

Issue: https://issues.redhat.com/browse/OBSDOCS-1652

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2025
@ocpdocs-previewbot
Copy link

🤖 Thu Feb 13 16:36:21 - Prow CI generated the docs preview:

https://88574--ocpdocs-pr.netlify.app/

Copy link

openshift-ci bot commented Feb 13, 2025

@jmagak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jmagak
Copy link
Author

jmagak commented Feb 13, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 13, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 13, 2025
@jeana-redhat
Copy link
Contributor

@jmagak there is no preview link here, and when I went looking for it, I don't see this content. Please make sure your changes are actually in the output and then re-submit for review, with a link to your changes.

@jeana-redhat jeana-redhat removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 13, 2025
@jmagak
Copy link
Author

jmagak commented Feb 13, 2025

@jmagak there is no preview link here, and when I went looking for it, I don't see this content. Please make sure your changes are actually in the output and then re-submit for review, with a link to your changes.

According to the Jira issue linked here, these changes apply only to versions 4.17 and 4.18. This explains why the cherry-pick failed for versions 4.15 and 4.16. As a result, this PR is not needed. I will proceed to close it. @jeana-redhat

@jmagak
Copy link
Author

jmagak commented Feb 13, 2025

/label do-not-merge

Copy link

openshift-ci bot commented Feb 13, 2025

@jmagak: The label(s) /label do-not-merge cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label do-not-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmagak jmagak closed this Feb 13, 2025
@jeana-redhat
Copy link
Contributor

@jmagak there is no preview link here, and when I went looking for it, I don't see this content. Please make sure your changes are actually in the output and then re-submit for review, with a link to your changes.

According to the Jira issue linked here, these changes apply only to versions 4.17 and 4.18. This explains why the cherry-pick failed for versions 4.15 and 4.16. As a result, this PR is not needed. I will proceed to close it. @jeana-redhat

Aha! makes sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants