Skip to content

Conversation

lahinson
Copy link
Contributor

@lahinson lahinson commented Feb 20, 2025

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2025
@lahinson lahinson added this to the Planned for 4.18 GA milestone Feb 20, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 20, 2025

🤖 Mon Feb 24 14:22:51 - Prow CI generated the docs preview:

https://88925--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-18-release-notes.html

@lahinson lahinson force-pushed the osdocs-13398-etcd-rn branch from d9177bc to 7445380 Compare February 20, 2025 02:26
@geliu2016
Copy link

geliu2016 commented Feb 20, 2025

Review the issue: https://issues.redhat.com/browse/OSDOCS-13398, it requires some updates which I have not find it in this pr, such as below item:

Lastly, please add a note saying that you can choose any of the surviving nodes to run the recovery, currently we say this Select a control plane host to use as the recovery host. You run the restore operation on this host.

@lahinson lahinson force-pushed the osdocs-13398-etcd-rn branch from 7445380 to 8dc236a Compare February 20, 2025 13:57
@lahinson lahinson force-pushed the osdocs-13398-etcd-rn branch from 8dc236a to ca2d9b2 Compare February 20, 2025 18:24
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2025
Copy link
Contributor

@kowen-rh kowen-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@dusk125
Copy link

dusk125 commented Feb 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
@lahinson lahinson added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 20, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2025
@lahinson lahinson force-pushed the osdocs-13398-etcd-rn branch from ca2d9b2 to 1259bc2 Compare February 24, 2025 14:08
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2025
@dusk125
Copy link

dusk125 commented Feb 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@sandeepknd
Copy link

/lgtm from QE.

Copy link

openshift-ci bot commented Feb 24, 2025

@lahinson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kalexand-rh kalexand-rh merged commit 575cffe into openshift:enterprise-4.18 Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.18 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants