Skip to content

RHDEVDOCS-6383 - fixed example file #89299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

RHDEVDOCS-6383 - fixed example file #89299

merged 1 commit into from
Mar 5, 2025

Conversation

deerskindoll
Copy link
Contributor

@deerskindoll deerskindoll commented Feb 27, 2025 •
edited
Loading

Version(s):

build-docs-main, cherry-pick to build-docs-1.2, build-docs-1.3, build-docs-1.4

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6383

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2025

Hi @deerskindoll. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eromanova97
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 27, 2025 •
edited
Loading

🤖 Fri Feb 28 00:56:52 - Prow CI generated the docs preview:

https://89299--ocpdocs-pr.netlify.app/openshift-builds/latest/work_with_builds/using-builds.html

@deerskindoll
fixed example file
203cce5 
moved callout
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2025

@deerskindoll: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ayushsatyam146
Copy link

LGTM @deerskindoll

@deerskindoll
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 3, 2025

@deerskindoll: Can not set label peer-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eromanova97
Copy link
Contributor

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 3, 2025
GroceryBoyJr
GroceryBoyJr reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 3, 2025
@deerskindoll
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 4, 2025

@deerskindoll: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eromanova97
Copy link
Contributor

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 4, 2025
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 4, 2025
bergerhoffer
bergerhoffer reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deerskindoll @eromanova97!

Actual change LGTM to merge.

But I don't see QE approval on this PR or in the Jira (just engineering). Can you get QE ack and then re-add to the merge queue?

@bergerhoffer bergerhoffer removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 4, 2025
@deerskindoll
Copy link
Contributor Author

hi @bergerhoffer this product doesn't have QE, that's why there's only dev approval in the PR and Jira

@bergerhoffer
Copy link
Contributor

hi @bergerhoffer this product doesn't have QE, that's why there's only dev approval in the PR and Jira

Hi, thanks for letting me know. I don't see build-docs listed as an exception in our docs manual as actual QE not required, so we need to update that if that's the case.

CC @kalexand-rh can you follow up on this once you're back from PTO (confirm+add to docs manual exception list)?

In the meantime, I'll go ahead with the merge, since I see precedent in past PRs for merging without official QE associate ack.

@bergerhoffer bergerhoffer merged commit 4d85010 into openshift:build-docs-main Mar 5, 2025
2 checks passed
@bergerhoffer
Copy link
Contributor

/cherrypick build-docs-1.2

@bergerhoffer
Copy link
Contributor

/cherrypick build-docs-1.3

@bergerhoffer
Copy link
Contributor

/cherrypick build-docs-1.4

@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #89639

In response to this:

/cherrypick build-docs-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2025
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #89640

In response to this:

/cherrypick build-docs-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2025
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #89641

In response to this:

/cherrypick build-docs-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2025
Merged
@deerskindoll
Copy link
Contributor Author

hi @bergerhoffer this product doesn't have QE, that's why there's only dev approval in the PR and Jira

Hi, thanks for letting me know. I don't see build-docs listed as an exception in our docs manual as actual QE not required, so we need to update that if that's the case.

CC @kalexand-rh can you follow up on this once you're back from PTO (confirm+add to docs manual exception list)?

In the meantime, I'll go ahead with the merge, since I see precedent in past PRs for merging without official QE associate ack.

@bergerhoffer Thanks so much for the merge and cherry-pick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

+1 more reviewer

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@deerskindoll @eromanova97 @ocpdocs-previewbot @ayushsatyam146 @GroceryBoyJr @bergerhoffer @openshift-cherrypick-robot