Skip to content

Conversation

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 7, 2025
Copy link

@unsortedhashsets unsortedhashsets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 7, 2025
@abrennan89 abrennan89 self-assigned this Mar 7, 2025
@abrennan89 abrennan89 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 7, 2025
@abrennan89 abrennan89 added this to the Continuous Release milestone Mar 7, 2025
@abrennan89 abrennan89 added the dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs label Mar 7, 2025
@abrennan89 abrennan89 changed the title OSSM-8991 Verify installation for OSSM 3 in doc OSSM-8991: Verify installation for OSSM 3 in doc Mar 7, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 7, 2025

Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question, otherwise lgtm!
/lgtm

@abrennan89 abrennan89 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 7, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Mar 7, 2025
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 7, 2025
@abrennan89 abrennan89 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 7, 2025
@gwynnemonahan
Copy link
Contributor Author

Rebased morning 03/07/2025

@abrennan89 abrennan89 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 7, 2025
@abrennan89 abrennan89 removed their assignment Mar 7, 2025
Copy link

openshift-ci bot commented Mar 7, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 7, 2025
@skrthomas
Copy link
Contributor

/lgtm

@skrthomas skrthomas removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 7, 2025
@skrthomas skrthomas merged commit b726262 into openshift:service-mesh-docs-main Mar 7, 2025
2 checks passed
@skrthomas
Copy link
Contributor

/cherrypick service-mesh-docs-3.0

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2025
@openshift-cherrypick-robot

@skrthomas: new pull request created: #89898

In response to this:

/cherrypick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants