Skip to content

Conversation

jmagak
Copy link

@jmagak jmagak commented Mar 25, 2025

Version(s): 4.17

Issue:

Link to docs preview: https://91034--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-release-notes.html#logging-release-notes-6-0-6_logging-6x

QE review: @anpingli

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2025

@jmagak: This pull request references OBSDOCS-1784 which is a valid jira issue.

In response to this:

Version(s): 4.17

Issue:

Link to docs preview:

QE review: @anpingli

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2025
@jmagak jmagak force-pushed the logging-6.0.6-rn-4.17 branch 2 times, most recently from a28895f to e2bbce2 Compare March 25, 2025 10:51
@anpingli
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2025

@jmagak: This pull request references OBSDOCS-1784 which is a valid jira issue.

In response to this:

Version(s): 4.17

Issue:

Link to docs preview:

QE review: @anpingli

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 25, 2025

Copy link
Contributor

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@jmagak jmagak force-pushed the logging-6.0.6-rn-4.17 branch from 52841a1 to abf57a2 Compare March 25, 2025 13:44
@jmagak jmagak requested a review from xperimental March 25, 2025 13:44
Copy link
Contributor

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2025

@jmagak: This pull request references OBSDOCS-1784 which is a valid jira issue.

In response to this:

Version(s): 4.17

Issue:

Link to docs preview:

QE review: @anpingli

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmagak
Copy link
Author

jmagak commented Mar 25, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 25, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2025

@jmagak: This pull request references OBSDOCS-1784 which is a valid jira issue.

In response to this:

Version(s): 4.17

Issue:

Link to docs preview: https://91034--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-release-notes.html#logging-release-notes-6-0-6_logging-6x

QE review: @anpingli

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion. Looks good overall!

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 25, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
Copy link

openshift-ci bot commented Mar 25, 2025

New changes are detected. LGTM label has been removed.

Logging 6.0.6 release notes

Logging 6.0.6 release notes

Logging 6.0.6 release notes

Logging 6.0.6 release notes
@jmagak jmagak force-pushed the logging-6.0.6-rn-4.17 branch from 36ae8ec to a1e4163 Compare March 25, 2025 15:49
Copy link

openshift-ci bot commented Mar 25, 2025

@jmagak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jmagak
Copy link
Author

jmagak commented Mar 25, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2025

@jmagak: This pull request references OBSDOCS-1784 which is a valid jira issue.

In response to this:

Version(s): 4.17

Issue:

Link to docs preview: https://91034--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-release-notes.html#logging-release-notes-6-0-6_logging-6x

QE review: @anpingli

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 26, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmagak Changes look good but can you please confirm the errata advisory is shipped live? Currently the errata link is not working.
Once the link works, this PR can be merged.

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 26, 2025
@jmagak
Copy link
Author

jmagak commented Mar 26, 2025

@jmagak Changes look good but can you please confirm the errata advisory is shipped live? Currently the errata link is not working. Once the link works, this PR can be merged.

@xenolinux, Sure, I can confirm that Errata advisory has been shipped live.

@jmagak
Copy link
Author

jmagak commented Mar 26, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 26, 2025
@jab-rh jab-rh merged commit 56739cb into openshift:enterprise-4.17 Mar 26, 2025
2 checks passed
@jab-rh jab-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.17 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants