Skip to content

CNV#57866: autoResourceLimits documentation needs update #92703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

CNV#57866: autoResourceLimits documentation needs update #92703

merged 1 commit into from
May 8, 2025

Conversation

danielclowers
Copy link
Contributor

@danielclowers danielclowers commented Apr 28, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 28, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 28, 2025 •
edited
Loading

🤖 Wed May 07 16:29:09 - Prow CI generated the docs preview:

https://92703--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-working-with-resource-quotas-for-vms.html
https://92703--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/storage/virt-configuring-cdi-for-namespace-resourcequota.html
https://92703--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/managing_vms/advanced_vm_management/virt-working-with-resource-quotas-for-vms.html
https://92703--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/storage/virt-configuring-cdi-for-namespace-resourcequota.html

@danielclowers danielclowers force-pushed the CNV-57866 branch 2 times, most recently from e144ebf to 10bdfdc Compare April 29, 2025 16:43
@danielclowers
Copy link
Contributor Author

/retest

@fossedihelm
Copy link

Looks good from my point of view!
Question: Do we want to mention that the memory multiplier can be adjusted (per namespace) through "alpha.kubevirt.io/auto-memory-limits-ratio" label?
Thanks

dshchedr
dshchedr reviewed May 2, 2025
View reviewed changes
modules/virt-setting-resource-quota-limits-for-vms.adoc
Comment on lines +7 to +11
= Enabling automatic resource quota limits for virtual machines

When the `AutoResourceLimits` feature gate is enabled, {VirtProductName} automatically manages CPU and memory limits for virtual machines.

By default, {VirtProductName} computes resource requests for a virtual machine. When you enable the `AutoResourceLimits` feature gate, {VirtProductName} also computes resource limits to meet namespace quota requirements.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: starting from v4.19 we have this feature enabled by default and AutoResourceLimits featuregate removed from hco

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for that information. for this purpose, i'll need to open a different PR for 4.19, and this PR will be for 4.16-4.18

@fossedihelm
Copy link

/lgtm
Thank you!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@dshchedr
Copy link

dshchedr commented May 6, 2025

/lgtm

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 6, 2025

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2025
@danielclowers danielclowers changed the base branch from main to enterprise-4.18 May 6, 2025 15:48
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 6, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2025
@danielclowers
Copy link
Contributor Author

/test validate-asciidoc

@danielclowers
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 6, 2025
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 6, 2025
mburke5678
mburke5678 reviewed May 6, 2025
View reviewed changes
mburke5678
mburke5678 reviewed May 6, 2025
View reviewed changes
@mburke5678
Copy link
Contributor

@danielclowers A couple of comments. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 6, 2025
@mburke5678 mburke5678 added this to the Continuous Release milestone May 6, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 7, 2025

@danielclowers: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danielclowers
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 7, 2025
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 8, 2025
@opayne1
Copy link
Contributor

opayne1 commented May 8, 2025

@mburke5678 got to it before me! but I was going to say it looks like this should be off the main branch and not enteerprise-4.18

@mburke5678 mburke5678 merged commit 2bb83ae into openshift:enterprise-4.18 May 8, 2025
2 checks passed
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.16

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #93146

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 8, 2025
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #93147

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

+1 more reviewer

@dshchedr dshchedr dshchedr left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@fossedihelm fossedihelm

@dshchedr dshchedr

Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@danielclowers @ocpdocs-previewbot @fossedihelm @dshchedr @mburke5678 @opayne1 @openshift-cherrypick-robot @openshift-merge-robot