Skip to content

Conversation

shdeshpa07
Copy link
Contributor

@shdeshpa07 shdeshpa07 commented May 22, 2025

Jira

must-gather docs for OCP 4.13

Version

  • OCP 4.13

Preview

QE Review

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 22, 2025
@shdeshpa07
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 17, 2025
@brendan-daly-red-hat
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 17, 2025
Copy link
Contributor

@brendan-daly-red-hat brendan-daly-red-hat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I provided some suggestions for your consideration.

I'm onboarding as a peer reviewer, so please wait for @skopacz1 to approve my review before you proceed.

Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments of my own, but peer review LGTM.

Also, friendly reminder to squash commits before requesting merge review

@brendan-daly-red-hat
Copy link
Contributor

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 17, 2025
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
@shdeshpa07 shdeshpa07 force-pushed the OADP-5384-must-gather-2.0-4.13 branch from 71109ac to 8a83892 Compare June 24, 2025 10:17
Copy link

openshift-ci bot commented Jun 24, 2025

@shdeshpa07: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anarnold97
Copy link
Contributor

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 25, 2025
@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 25, 2025
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ShaunaDiaz ShaunaDiaz merged commit 8c344e5 into openshift:enterprise-4.13 Jun 25, 2025
2 checks passed
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2025
@shdeshpa07 shdeshpa07 deleted the OADP-5384-must-gather-2.0-4.13 branch July 25, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants