-
Notifications
You must be signed in to change notification settings - Fork 1.8k
must-gather for 4.13 #93670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
must-gather for 4.13 #93670
Conversation
/label peer-review-needed |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I provided some suggestions for your consideration.
I'm onboarding as a peer reviewer, so please wait for @skopacz1 to approve my review before you proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments of my own, but peer review LGTM.
Also, friendly reminder to squash commits before requesting merge review
/remove-label peer-review-needed |
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
71109ac
to
8a83892
Compare
@shdeshpa07: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Jira
must-gather docs for OCP 4.13
Version
Preview
QE Review