-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-14604: Add RN for OCPSTRAT-1577 #94505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sslocket: This pull request references OSDOCS-14604 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Wed Jun 11 14:11:58 - Prow CI generated the docs preview: |
@sgaoshang PTAL when you can. |
@sslocket: This pull request references OSDOCS-14604 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good! The only required thing here is to be sure to include (Technology Preview)
in the title of a TP feature description.
If it's not in another PR, make sure this feature is added to the tech preview tracker table too.
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
For more information, see xref:../updating/preparing_for_updates/updating-cluster-prepare.adoc#updating-cluster-prepare[Preparing to update to {product-title} 4.19]. | ||
|
||
[id="ocp-4-19-vsphere-host-groups_{context}"] | ||
==== OpenShift zones support for vSphere host groups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar enough with this one, but is there anything it could be called other than "OpenShift zones" that would allow us to not have "OpenShift" by itself in plain text? If not, it is what it is 🤓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeana-redhat I asked PM if that was the literal feature title and was told yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for checking!
For more information, see xref:../updating/preparing_for_updates/updating-cluster-prepare.adoc#updating-cluster-prepare[Preparing to update to {product-title} 4.19]. | ||
|
||
[id="ocp-4-19-vsphere-host-groups_{context}"] | ||
==== OpenShift zones support for vSphere host groups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
==== OpenShift zones support for vSphere host groups | |
==== OpenShift zones support for vSphere host groups (Technology Preview) |
|
||
With this release, you can map {product-title} failure domains to {vmw-full} host groups. This enables you to make use of the high availability offered by a {vmw-short} stretched cluster configuration. This feature is available as a Technology Preview in {product-title} {product-version}. | ||
|
||
For more information on Technology Preview features, see xref:../nodes/clusters/nodes-cluster-enabling-features.adoc#nodes-cluster-enabling[Enabling features using feature gates]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably leave this off, since it's common. Not hurting anything though.
/lgtm |
@sslocket: This pull request references OSDOCS-14604 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label merge-review-needed |
New changes are detected. LGTM label has been removed. |
@sslocket: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Merge review LGTM. |
Version(s):
4.19
Issue:
https://issues.redhat.com/browse/OSDOCS-14604
Link to docs preview:
https://94505--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-19-release-notes.html#ocp-4-19-vsphere-host-groups_release-notes
QE review:
Additional information: