Skip to content

Conversation

sslocket
Copy link
Contributor

@sslocket sslocket commented Jun 10, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025

@sslocket: This pull request references OSDOCS-14604 which is a valid jira issue.

In response to this:

Version(s):

4.19

Issue:

https://issues.redhat.com/browse/OSDOCS-14604

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 10, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 10, 2025

🤖 Wed Jun 11 14:11:58 - Prow CI generated the docs preview:

https://94505--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-19-release-notes.html

@sslocket
Copy link
Contributor Author

@sgaoshang PTAL when you can.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025

@sslocket: This pull request references OSDOCS-14604 which is a valid jira issue.

In response to this:

Version(s):

4.19

Issue:

https://issues.redhat.com/browse/OSDOCS-14604

Link to docs preview:

https://94505--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-19-release-notes.html#ocp-4-19-vsphere-host-groups_release-notes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sslocket
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 10, 2025
@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 10, 2025
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good! The only required thing here is to be sure to include (Technology Preview) in the title of a TP feature description.

If it's not in another PR, make sure this feature is added to the tech preview tracker table too.

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

For more information, see xref:../updating/preparing_for_updates/updating-cluster-prepare.adoc#updating-cluster-prepare[Preparing to update to {product-title} 4.19].

[id="ocp-4-19-vsphere-host-groups_{context}"]
==== OpenShift zones support for vSphere host groups
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with this one, but is there anything it could be called other than "OpenShift zones" that would allow us to not have "OpenShift" by itself in plain text? If not, it is what it is 🤓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeana-redhat I asked PM if that was the literal feature title and was told yes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking!

For more information, see xref:../updating/preparing_for_updates/updating-cluster-prepare.adoc#updating-cluster-prepare[Preparing to update to {product-title} 4.19].

[id="ocp-4-19-vsphere-host-groups_{context}"]
==== OpenShift zones support for vSphere host groups
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
==== OpenShift zones support for vSphere host groups
==== OpenShift zones support for vSphere host groups (Technology Preview)


With this release, you can map {product-title} failure domains to {vmw-full} host groups. This enables you to make use of the high availability offered by a {vmw-short} stretched cluster configuration. This feature is available as a Technology Preview in {product-title} {product-version}.

For more information on Technology Preview features, see xref:../nodes/clusters/nodes-cluster-enabling-features.adoc#nodes-cluster-enabling[Enabling features using feature gates].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably leave this off, since it's common. Not hurting anything though.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 10, 2025
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 10, 2025
@sgaoshang
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 11, 2025

@sslocket: This pull request references OSDOCS-14604 which is a valid jira issue.

In response to this:

Version(s):

4.19

Issue:

https://issues.redhat.com/browse/OSDOCS-14604

Link to docs preview:

https://94505--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-19-release-notes.html#ocp-4-19-vsphere-host-groups_release-notes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sslocket
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 11, 2025
@bscott-rh bscott-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 11, 2025
@bscott-rh bscott-rh added this to the Planned for 4.19 GA milestone Jun 11, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
Copy link

openshift-ci bot commented Jun 11, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2025
Copy link

openshift-ci bot commented Jun 11, 2025

@sslocket: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Jun 11, 2025
@bscott-rh
Copy link
Contributor

Merge review LGTM.

@bscott-rh bscott-rh merged commit 0fe766e into openshift:enterprise-4.19 Jun 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants