-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-14689_2#adding TP to RN #94690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-14689_2#adding TP to RN #94690
Conversation
🤖 Thu Jun 12 15:33:37 - Prow CI generated the docs preview: |
/label peer-review-needed |
/label peer-review-in-progress |
|
||
With this release, you can enable a user-provisioned domain name server (DNS) instead of the default cluster-provisioned DNS solution. For example, your organization's security policies might not allow the use of public DNS services such as Google Cloud DNS. You can manage your DNS only for the IP addresses of the API and Ingress servers. If you use this feature, you must provide your own DNS solution that includes records for `api.<cluster_name>.<base_domain>.` and `*.apps.<cluster_name>.<base_domain>.`. | ||
With this release, you can enable a user-provisioned domain name server (DNS) as a Technology Preview feature instead of the default cluster-provisioned DNS solution. For example, your organization's security policies might not allow the use of public DNS services such as Google Cloud DNS. You can manage your DNS only for the IP addresses of the API and Ingress servers. If you use this feature, you must provide your own DNS solution that includes records for `api.<cluster_name>.<base_domain>.` and `*.apps.<cluster_name>.<base_domain>.`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay, but I don't love the placement of this addition. It kind of interrupts the flow of the sentence. When I come across that with mine, I usually just add a sentence like " is available as a Technology Preview feature" or something similar.
If you search the RNs for "as a Technology Preview", you'll find some examples. Just something to consider!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this sentence at the end: "Enabling a user-provisioned DNS is available as a Technology Preview feature."
/label peer-review-done |
9d97478
to
9a1490e
Compare
@brendan-daly-red-hat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Version:
4.19
Issue:
https://issues.redhat.com/browse/OSDOCS-14689
Link to docs preview:
Installing a cluster on Google Cloud Platform (GCP) with a user-provisioned DNS (Technology Preview)
QE review:
Additional information:
This feature is TP. The original RN PR (#93403) didn't indicate this status, so this PR is to correct that omission.