Skip to content

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Jun 24, 2025

https://issues.redhat.com/browse/OSDOCS-14786 [NETOBSERV] Add section for IPsec

Version(s):
Merge to only the no-1.9 branch - no cherrypicks are required.
I will open one PR against main to incorporate all of the NetObserv content just before its GA.

Cherry-pick to OCP 4.12, 4.14, 4.16+

Issue:
https://issues.redhat.com/browse/OSDOCS-14786

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Redo/copy of #93858 which I somehow messed up. So this is a copy of the Dev/QE approved PR, and making this copy revealed that the content in the following already merged PRs is no longer present in the no-1.9 branch:

The only new content is proc_working-with-ipsec.adoc, and this addition to observing-network-traffic.adoc for IPsec:

include::modules/proc_network-observability-working-with-ipsec.adoc[leveloffset=+2]

[role="_additional-resources"]
.Additional resources
*xref:../../networking/network_security/configuring-ipsec-ovn.adoc#configuring-ipsec-ovn[Configuring IPsec encryption]

//Traffic flows continued

The remaining files have been reviewed and merged as part of the PRs listed above. However, removing those files results in build failures as that content has vanished from the no-1.9 branch for reasons no one has been able to identify.

The previously reviewed and merged content is now part of this PR, and hopefully this will fix the no-1.9 branch and return it to its updated state with all NetObserv 1.9 content. And hopefully that will resolve existing open PRs against no-1.9 that now have these same previously merged PRs.

Copied from 93858:
API reference updates are being handled by #94756

First time doing NETOBSERV release, and did not realize API/CLI changes were automatically generated, and those updates to prod docs are generally handed separately and not in individual PRs where CLI/API changes may occur.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2025
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 24, 2025
@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 24, 2025
@gabriel-rh gabriel-rh added peer-review-in-progress Signifies that the peer review team is reviewing this PR netobserv and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 26, 2025
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Good work on very technical info - only a few trivial comments

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
@gabriel-rh gabriel-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR lgtm Indicates that a PR is ready to be merged. labels Jun 26, 2025
@gwynnemonahan
Copy link
Contributor Author

Here's hoping merging this PR puts all the files back in the no-1.9 branch, that a rebase of existing open PRs against no-1.9 works, and all returns to normal.

@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 26, 2025
@lahinson lahinson added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 27, 2025
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits for your consideration. Let me know when you've reviewed the comments and made any changes, and I'll merge this.

* xref:../../networking/multiple_networks/primary_networks/about-user-defined-networks.adoc#nw-udn-cr_about-user-defined-networks[Creating a UserDefinedNetwork by using the CLI]
* xref:../../networking/multiple_networks/primary_networks/about-user-defined-networks.adoc#nw-udn-cr-ui_about-user-defined-networks[Creating a UserDefinedNetwork by using the web console]
include::modules/network-observability-viewing-network-events.adoc[leveloffset=+2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of your changes here, but in the preview, I noticed some wonky formatting in this file:
Screenshot 2025-06-27 at 11 24 31 AM

Copy link

openshift-ci bot commented Jun 27, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating my suggestions! Merging now :)

@lahinson lahinson merged commit 5c96d1c into openshift:no-1.9 Jun 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-review-in-progress Signifies that the merge review team is reviewing this PR netobserv peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants