Skip to content

TELCODOCS-2339: Fixing optionality for community.yaml #95636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

TELCODOCS-2339: Fixing optionality for community.yaml #95636

merged 1 commit into from
Jul 8, 2025

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Jul 4, 2025 •
edited
Loading

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 4, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2339: Fixing optionality for community.yaml

Version(s):

Issue:
https://issues.redhat.com/browse/TELCODOCS-2339

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 4, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 4, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2339: Fixing optionality for community.yaml

Version(s):
4.16+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2339

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

🤖 Fri Jul 04 09:59:19 - Prow CI generated the docs preview:

https://95636--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco-core-rds.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 4, 2025

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@irinamihai
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2025
@dgonyier
Copy link

dgonyier commented Jul 7, 2025

Lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 8, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2339: Fixing optionality for community.yaml

Version(s):
4.16+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2339

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes
Copy link
Contributor Author

rohennes commented Jul 8, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 8, 2025
@eromanova97
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 8, 2025
eromanova97
eromanova97 reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor

@eromanova97 eromanova97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would just suggest adding link to the preview: https://95636--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco-core-rds.html#networking-crs_telco-core

Thank you!

/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 8, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

TELCODOCS-2339: Fixing optionality for community.yaml

Version(s):
4.16+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2339

Link to docs preview:
https://95636--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco-core-rds.html#networking-crs_telco-core

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes
Copy link
Contributor Author

rohennes commented Jul 8, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 8, 2025
@dfitzmau dfitzmau added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 8, 2025
@dfitzmau dfitzmau merged commit ffec83d into openshift:main Jul 8, 2025
2 checks passed
@dfitzmau
Copy link
Contributor

dfitzmau commented Jul 8, 2025

/cherrypick enterprise-4.20

@dfitzmau
Copy link
Contributor

dfitzmau commented Jul 8, 2025

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor

dfitzmau commented Jul 8, 2025

/cherrypick enterprise-4.18

@dfitzmau
Copy link
Contributor

dfitzmau commented Jul 8, 2025

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor

dfitzmau commented Jul 8, 2025

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #95744

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 8, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #95745

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jul 8, 2025
Merged
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #95746

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: #95636 failed to apply on top of branch "enterprise-4.17":

Applying: TELCODOCS-2339: Fixing optionality for community.yaml
error: patch failed: modules/telco-core-crs-networking.adoc:17
error: modules/telco-core-crs-networking.adoc: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Using index info to reconstruct a base tree...
M	modules/telco-core-crs-networking.adoc
Patch failed at 0001 TELCODOCS-2339: Fixing optionality for community.yaml

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: #95636 failed to apply on top of branch "enterprise-4.16":

Applying: TELCODOCS-2339: Fixing optionality for community.yaml
error: patch failed: modules/telco-core-crs-networking.adoc:17
error: modules/telco-core-crs-networking.adoc: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Using index info to reconstruct a base tree...
M	modules/telco-core-crs-networking.adoc
Patch failed at 0001 TELCODOCS-2339: Fixing optionality for community.yaml

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jul 10, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromanova97 eromanova97 eromanova97 left review comments

Assignees

@irinamihai irinamihai

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rohennes @openshift-ci-robot @ocpdocs-previewbot @irinamihai @dgonyier @eromanova97 @dfitzmau @openshift-cherrypick-robot