-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-6486 builds 1.5 release notes #95905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-6486 builds 1.5 release notes #95905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor updates on the CLI.
9d00092
to
85e1703
Compare
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few typos; the rest looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that you have multiple commits. If your product does not require squashing to one commit, not problem. Otherwise, please squash.
A couple of comments. Otherwise, LGTM!
146bc2e
to
0f5c80a
Compare
suggestions applied, commits squashed |
/label merge-review-needed |
🤖 Mon Jul 21 13:43:08 - Prow CI generated the docs preview: https://95905--ocpdocs-pr.netlify.app/ |
feedback feedback Update modules/ob-release-notes-1-5.adoc Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com> Update modules/ob-release-notes-1-5.adoc Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com> Update modules/ob-release-notes-1-5.adoc Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com> Update modules/ob-release-notes-1-5.adoc Co-authored-by: Lisa Pettyjohn <lpettyjo@redhat.com> Update modules/ob-release-notes-1-5.adoc Co-authored-by: Lisa Pettyjohn <lpettyjo@redhat.com> feedback
1712445
to
994b0ee
Compare
/test all |
2 similar comments
/test all |
/test all |
@deerskindoll: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
Version(s):
build-docs-1.5
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-6486
Link to docs preview:
https://95905--ocpdocs-pr.netlify.app/openshift-builds/latest/release_notes/ob-release-notes.html
QE review:
builds has no QE team
Additional information: