Skip to content

Conversation

deerskindoll
Copy link
Contributor

@deerskindoll deerskindoll commented Jul 10, 2025

Version(s):

build-docs-1.5

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6486

Link to docs preview:
https://95905--ocpdocs-pr.netlify.app/openshift-builds/latest/release_notes/ob-release-notes.html

QE review:

  • QE has approved this change.

builds has no QE team

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2025
Copy link

@sayan-biswas sayan-biswas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor updates on the CLI.

@deerskindoll deerskindoll changed the title RHDEVDOCS-6488 builds 1.5 release notes RHDEVDOCS-6486 builds 1.5 release notes Jul 15, 2025
@deerskindoll
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 17, 2025
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few typos; the rest looks good to me.

@lpettyjo lpettyjo self-requested a review July 18, 2025 13:43
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 18, 2025
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that you have multiple commits. If your product does not require squashing to one commit, not problem. Otherwise, please squash.

A couple of comments. Otherwise, LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 18, 2025
@deerskindoll
Copy link
Contributor Author

I notice that you have multiple commits. If your product does not require squashing to one commit, not problem. Otherwise, please squash.

A couple of comments. Otherwise, LGTM!

suggestions applied, commits squashed

@deerskindoll
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 18, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 18, 2025

@gabriel-rh gabriel-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 21, 2025
feedback

feedback

Update modules/ob-release-notes-1-5.adoc

Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com>

Update modules/ob-release-notes-1-5.adoc

Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com>

Update modules/ob-release-notes-1-5.adoc

Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com>

Update modules/ob-release-notes-1-5.adoc

Co-authored-by: Lisa Pettyjohn <lpettyjo@redhat.com>

Update modules/ob-release-notes-1-5.adoc

Co-authored-by: Lisa Pettyjohn <lpettyjo@redhat.com>

feedback
@gabriel-rh
Copy link
Contributor

/test all

2 similar comments
@gabriel-rh
Copy link
Contributor

/test all

@gabriel-rh
Copy link
Contributor

/test all

Copy link

openshift-ci bot commented Jul 21, 2025

@deerskindoll: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@gabriel-rh gabriel-rh merged commit 4f70782 into openshift:build-docs-1.5 Jul 21, 2025
2 checks passed
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2025
@gabriel-rh gabriel-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants