OSDOCS-15304#Performance plus for Azure Disk #96181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/L
lpettyjo
added
peer-review-needed
|
🤖 Mon Sep 22 19:34:03 - Prow CI generated the docs preview: |
|
/remove-label peer-review-needed |
openshift-ci
bot
added
peer-review-in-progress
tmalove
approved these changes
Jul 16, 2025
modules/persistent-storage-csi-azure-disk-perf-plus-create-new-disk.adoc
Outdated
Show resolved
Hide resolved
|
/remove-label peer-review-in-progress |
openshift-ci
bot
added
peer-review-done
lpettyjo
force-pushed
the
OSDOCS-15304
branch
2 times, most recently
from
3f480a0 to
7a44d5d
Compare
gcharot
reviewed
Jul 21, 2025
gcharot
reviewed
Jul 21, 2025
modules/persistent-storage-csi-azure-disk-perf-plus-create-new-disk.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
Jul 21, 2025
modules/persistent-storage-csi-azure-disk-perf-plus-limits.adoc
Outdated
Show resolved
Hide resolved
gcharot
reviewed
Jul 21, 2025
modules/persistent-storage-csi-azure-disk-perf-plus-from-snapshots.adoc
Outdated
Show resolved
Hide resolved
duanwei33
reviewed
Jul 23, 2025
modules/persistent-storage-csi-azure-disk-perf-plus-limits.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-azure-disk-perf-plus-create-new-disk.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-azure-disk-perf-plus-from-snapshots.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-azure-disk-perf-plus-limits.adoc
Outdated
Show resolved
Hide resolved
lpettyjo
force-pushed
the
OSDOCS-15304
branch
3 times, most recently
from
9f7e1fa to
ca8f780
Compare
duanwei33
reviewed
Aug 8, 2025
modules/persistent-storage-csi-azure-disk-perf-plus-create-new-disk.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-azure-disk-perf-plus-from-snapshots.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-azure-disk-perf-plus-create-new-disk.adoc
Show resolved
Hide resolved
jsafrane
reviewed
Aug 26, 2025
lpettyjo
force-pushed
the
OSDOCS-15304
branch
from
f1a54dd to
71f6e42
Compare
|
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
lgtm |
duanwei33
reviewed
Oct 9, 2025
|
|
||
| include::modules/persistent-storage-csi-azure-disk-perf-plus-limits.adoc[leveloffset=+2] | ||
|
|
||
| include::modules/persistent-storage-csi-azure-disk-perf-plus-create-new-disk.adoc[leveloffset=+2] |
There was a problem hiding this comment.
@lpettyjo Thanks for the update. The content itself looks solid! I have a couple of suggestions regarding the structure and naming to improve clarity.
- Module Naming: What do you think about renaming the new module to be more descriptive? Since the content also covers creating disks from snapshots and clones, a name like ...-create-new-disk-by-snapshot-clone.adoc might better reflect its full scope.
Suggested change
| include::modules/persistent-storage-csi-azure-disk-perf-plus-create-new-disk.adoc[leveloffset=+2] | |
| include::modules/persistent-storage-csi-azure-disk-perf-plus-create-new-disk-by-snapshot-clone.adoc[leveloffset=+2] |
- Module Order (More importantly): To ensure a logical flow, could we move this module to appear after the persistent-storage-csi-azure-disk-perf-plus-sc module? The -sc module introduces how to create a StorageClass, which is a prerequisite for the snapshot and clone operations described here. Presenting the StorageClass creation first would make it easier for users to follow along.
Let me know if it makes sense to you, thanks!
There was a problem hiding this comment.
Agree to put the storage class creation chapter before the snap/clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s): 4.20+
Issue: https://issues.redhat.com/browse/OSDOCS-15304
Link to docs preview: https://96181--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-azure.html#performance-plus-for-azure-disk
QE review:
Additional information:
PTAL: @gcharot @duanwei33 @jsafrane