-
Notifications
You must be signed in to change notification settings - Fork 1.8k
docs: added a getting started section for managing cluster configuration #97342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gnunn1, Could you please review the PR? Thanks |
@varshab1210, Could you please review the PR from the QE side? Thanks |
managing_cluster_configuration/managing-openshift-cluster-configuration.adoc
Outdated
Show resolved
Hide resolved
Thank you for the suggestions, @gnunn1. I have incorporated all of them. Could you please verify and confirm? |
managing_cluster_configuration/managing-openshift-cluster-configuration.adoc
Show resolved
Hide resolved
@varshab1210, Incorporated your suggestions. Could you please verify and confirm? Thanks |
@shipsing I had two comments for you to consider. Otherwise, lgtm |
@shivanisathe25, could you please submit your comments? Thanks |
managing_cluster_configuration/managing-openshift-cluster-configuration.adoc
Show resolved
Hide resolved
LGTM |
fd1a99e
to
88798a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a few minor suggestions
managing_cluster_configuration/managing-openshift-cluster-configuration.adoc
Outdated
Show resolved
Hide resolved
3711a54
to
1135466
Compare
Signed-off-by: Shipra Singh <shipsing@redhat.com>
e31d992
to
abe0a32
Compare
@shipsing: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick gitops-docs-1.17 |
/cherrypick gitops-docs-1.18 |
@gabriel-rh: new pull request created: #98411 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@gabriel-rh: new pull request created: #98412 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): gitops-docs-1.17, gitops-docs-1.18
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-6501
The chapter will be part of the get started section here.
Link to docs preview:
https://97342--ocpdocs-pr.netlify.app/openshift-gitops/latest/managing_cluster_configuration/managing-openshift-cluster-configuration
QE review:
SME review: @gnunn1
QE review: @varshab1210
Peer review: @shivanisathe25
Additional information: