Skip to content

Conversation

shipsing
Copy link
Contributor

@shipsing shipsing commented Aug 8, 2025

Version(s): gitops-docs-1.17, gitops-docs-1.18

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-6501
The chapter will be part of the get started section here.
Link to docs preview:
https://97342--ocpdocs-pr.netlify.app/openshift-gitops/latest/managing_cluster_configuration/managing-openshift-cluster-configuration

QE review:

  • QE has approved this change.

SME review: @gnunn1
QE review: @varshab1210
Peer review: @shivanisathe25

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 8, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 8, 2025

@shipsing
Copy link
Contributor Author

@svghadi @jgwest @jannfis, Could you please review the PR? Thanks

@shipsing
Copy link
Contributor Author

@gnunn1, Could you please review the PR? Thanks

@shipsing
Copy link
Contributor Author

@varshab1210, Could you please review the PR from the QE side? Thanks

@shipsing
Copy link
Contributor Author

Thank you for the suggestions, @gnunn1. I have incorporated all of them. Could you please verify and confirm?

@shipsing
Copy link
Contributor Author

@varshab1210, Incorporated your suggestions. Could you please verify and confirm? Thanks

@shivanisathe25
Copy link
Contributor

@shipsing I had two comments for you to consider. Otherwise, lgtm

@shipsing
Copy link
Contributor Author

@shivanisathe25, could you please submit your comments? Thanks

@varshab1210
Copy link

LGTM

Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few minor suggestions

Signed-off-by: Shipra Singh <shipsing@redhat.com>
Copy link

openshift-ci bot commented Sep 3, 2025

@shipsing: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gabriel-rh gabriel-rh merged commit bb0ce3e into openshift:gitops-docs-main Sep 3, 2025
2 checks passed
@gabriel-rh
Copy link
Contributor

/cherrypick gitops-docs-1.17

@gabriel-rh
Copy link
Contributor

/cherrypick gitops-docs-1.18

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #98411

In response to this:

/cherrypick gitops-docs-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #98412

In response to this:

/cherrypick gitops-docs-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants