Skip to content

Conversation

max-cx
Copy link
Contributor

@max-cx max-cx commented Aug 18, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 18, 2025

@max-cx: This pull request references OBSDOCS-2245 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 18, 2025

@max-cx: This pull request references OBSDOCS-2245 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): OCP 4.12+

Issue: https://issues.redhat.com/browse/OBSDOCS-2245

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx max-cx marked this pull request as draft August 18, 2025 16:14
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
@max-cx max-cx marked this pull request as ready for review August 18, 2025 16:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 18, 2025

🤖 Mon Sep 29 09:54:25 - Prow CI generated the docs preview:
https://97682--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@max-cx max-cx force-pushed the OBSDOCS-2245 branch 4 times, most recently from 986ab12 to 0ed2b34 Compare August 19, 2025 09:00
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2025
@max-cx max-cx force-pushed the OBSDOCS-2245 branch 3 times, most recently from 8f09bda to 8b58a87 Compare August 19, 2025 16:49
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 20, 2025

@max-cx: This pull request references OBSDOCS-2245 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): OCP 4.12+

Issue: https://issues.redhat.com/browse/OBSDOCS-2245

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx max-cx force-pushed the OBSDOCS-2245 branch 2 times, most recently from acc1b67 to 1660e33 Compare August 27, 2025 12:51
@eromanova97 eromanova97 force-pushed the OBSDOCS-2245 branch 2 times, most recently from bd51844 to 0dc8960 Compare September 26, 2025 13:06
Copy link
Contributor Author

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub on Android is super-buggy, so I'm posting this as a comment if in luck:

In file modules/distr-tracing-tempo-rn-known-issues.adoc

In the Jaeger UI, clicking on *Trace* and refreshing the page, or accessing *Trace* -> *Trace Timeline* -> *Trace JSON* from the Tempo query frontend, might result in the Tempo query pod failing with an EOF error.
...
link:https://issues.redhat.com/browse/TRACING-5483[TRACING-5483]

I suggest revisiting the output posted in the description of this Jira. Same as you, @eromanova97, I wasn't impressed with Renoa's output on this issue. For example, the result is a "500 error". Also, asking Ishwar can give you a wording suggestion and a QE review.
Also, I suggest checking this Jira link because I might have moved this Jira into the OBSDOC Jira project or cloned it.

Copy link
Contributor

@shivanisathe25 shivanisathe25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eromanova97 The PR looks good. Just had one comment for you to consider. Overall lgtm :)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2025

@max-cx: This pull request references OBSDOCS-2245 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s): OCP 4.12+

Issue: https://issues.redhat.com/browse/OBSDOCS-2245

Link to docs preview:
[Eliska] - updated links to show all the changes I found from Max:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97 eromanova97 force-pushed the OBSDOCS-2245 branch 2 times, most recently from e098d9d to 7808f9b Compare September 29, 2025 08:51
Copy link

openshift-ci bot commented Sep 29, 2025

@max-cx: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor

This issue has been merged as part of this PR: #96782
So this one can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants