-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS-59206-15: Added proxy attribute to the Insights Operator configu #97880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dfitzmau: This pull request references Jira Issue OCPBUGS-60660, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6dcffa7
to
48aefc8
Compare
🤖 Fri Aug 29 15:29:57 - Prow CI generated the docs preview: |
/lgtm |
/lgtm |
/label mergre-review-in-progress |
@michaelryanpeter: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment to consider before you merge.
|
||
.Insights Operator configurable attributes | ||
[options="header"] | ||
[cols=".^2l,.^3a,.^1a,.^1a",options="header"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description table renders really small. Could you expand it? maybe something else could be reduced if there's a size limitation?
Then again, I'm not exactly sure how this will render on docs.rh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dfitzmau: This pull request references Jira Issue OCPBUGS-59206, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
48aefc8
to
28dcbb4
Compare
New changes are detected. LGTM label has been removed. |
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@dfitzmau: Jira Issue OCPBUGS-59206: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-59206 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick enterprise-4.14 |
@dfitzmau: #97880 failed to apply on top of branch "enterprise-4.14":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.15 and 4.14.
Issue:
OCPBUGS-59206
Link to docs preview:
SME and QE on holidays