Skip to content

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Aug 21, 2025

Version(s):
4.15 and 4.14.

Issue:
OCPBUGS-59206

Link to docs preview:

SME and QE on holidays

  • SME has approved this change (Harshada Patil/Ondrej Pokorny ).
  • QE has approved this change (baiyang zhou) > Waiting on version support info.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-60660, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-60660 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 21, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 21, 2025

@BaiyangZhou
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2025
@opokornyy
Copy link

/lgtm

@dfitzmau dfitzmau added branch/enterprise-4.14 branch/enterprise-4.15 merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 29, 2025
@michaelryanpeter michaelryanpeter added this to the Continuous Release milestone Aug 29, 2025
@michaelryanpeter
Copy link
Contributor

/label mergre-review-in-progress

Copy link

openshift-ci bot commented Aug 29, 2025

@michaelryanpeter: The label(s) /label mergre-review-in-progress cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, ok-to-test, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, stability-fix-approved, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label mergre-review-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 29, 2025
Copy link
Member

@stevsmit stevsmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment to consider before you merge.


.Insights Operator configurable attributes
[options="header"]
[cols=".^2l,.^3a,.^1a,.^1a",options="header"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description table renders really small. Could you expand it? maybe something else could be reduced if there's a size limitation?

Then again, I'm not exactly sure how this will render on docs.rh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, Steve. I have Value type and Default value columns at the lowest level. The customer portal has a better experience where a customer can expand the table real estate:

Screenshot From 2025-08-29 16-19-14

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Gemini:

Screenshot From 2025-08-29 16-29-18

@stevsmit stevsmit added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Aug 29, 2025
@dfitzmau dfitzmau changed the title OCPBUGS-60660-15: Added proxy attribute to the Insights Operator configu OCPBUGS-59206-15: Added proxy attribute to the Insights Operator configu Aug 29, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-59206, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-59206 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.15 and 4.14.

Issue:
OCPBUGS-59206

Link to docs preview:

SME and QE on holidays

  • SME has approved this change (Harshada Patil/Ondrej Pokorny ).
  • QE has approved this change (baiyang zhou) > Waiting on version support info.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2025
Copy link

openshift-ci bot commented Aug 29, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Aug 29, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit aebcab2 into openshift:enterprise-4.15 Aug 29, 2025
2 checks passed
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-59206: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59206 has been moved to the MODIFIED state.

In response to this:

Version(s):
4.15 and 4.14.

Issue:
OCPBUGS-59206

Link to docs preview:

SME and QE on holidays

  • SME has approved this change (Harshada Patil/Ondrej Pokorny ).
  • QE has approved this change (baiyang zhou) > Waiting on version support info.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

/cherry-pick enterprise-4.14

@openshift-cherrypick-robot

@dfitzmau: #97880 failed to apply on top of branch "enterprise-4.14":

Applying: OCPBUGS-60660-15: Added proxy attribute to the Insights Operator configu
.git/rebase-apply/patch:64: trailing whitespace.
|httpProxy, 
.git/rebase-apply/patch:65: trailing whitespace.
 httpsProxy, 
.git/rebase-apply/patch:71: trailing whitespace.
|interval 
.git/rebase-apply/patch:76: trailing whitespace.
|reportEndpoint 
.git/rebase-apply/patch:86: trailing whitespace.
|reportPullingTimeout 
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	modules/insights-operator-configuring.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/insights-operator-configuring.adoc
CONFLICT (content): Merge conflict in modules/insights-operator-configuring.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-60660-15: Added proxy attribute to the Insights Operator configu

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-merge size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants