-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OLS-2045: Inform user about expected prompt output on OLS when using… #98222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rh-tokeefe: No Jira issue with key OLS-20245 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: No Jira issue with key OLS-20245 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Tue Sep 09 14:29:54 - Prow CI generated the docs preview: |
@rh-tokeefe: No Jira issue with key OLS-20245 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes requested
|
||
The {ols-long} Service does not configure the delineator behavior or produce the delineators in the output. The delineator feature is a model configuration setting. Typically, you can disable the feature using one of the following methods: | ||
|
||
* Append your question prompt with the specific keyword that the model requires to toggle the delineator feature off. For example, `/nothink`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to specify that this is dependent on the model and the model's documentation should indicate if this works or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
The {ols-long} Service does not configure the delineator behavior or produce the delineators in the output. The delineator feature is a model configuration setting. Typically, you can disable the feature using one of the following methods: | ||
|
||
* Append your question prompt with the specific keyword that the model requires to toggle the delineator feature off. For example, `/nothink`. | ||
* Use API configuration settings in the model to turn the delineator feature off No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be reworded to say that the inference server configuration may need to be modified to disable this, and that would be in the docs for the inference server and/or the model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@rh-tokeefe: This pull request references OLS-2045 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
LGTM |
05d4b9f
to
03f8748
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - very minor comment
|
||
The {ols-long} Service does not configure the delineator behavior or produce the delineators in the output. The delineator feature is a model configuration setting. Typically, you can disable the feature using one of the following methods: | ||
|
||
* Append your question prompt with the specific keyword that the model requires to disable the delineator feature. For example, `/nothink`. For more information, see the documentation for the model you are using. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disable the delineator feature, for example,
Maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@rh-tokeefe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick lightspeed-docs-1.0 |
@rh-tokeefe: new pull request created: #98734 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Affects:
lightspeed-main
lightspeed-docs-1.0
PR must be CP'd back to the lightspeed-docs-1.0 branch.
Version(s):
Issue: https://issues.redhat.com/browse/OLS-2046
Link to docs preview:
https://98222--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/troubleshoot/ols-troubleshooting-openshift-lightspeed.html#ols-thinking-model-generates-delineator-prompt_ols-troubleshooting-openshift-lightspeed
QE review:
Additional information: