Skip to content

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Aug 28, 2025

@openshift-ci-robot
Copy link

@rh-tokeefe: No Jira issue with key OLS-20245 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

… thinking model

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2025
@openshift-ci-robot
Copy link

@rh-tokeefe: No Jira issue with key OLS-20245 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0

PR must be CP'd back to the lightspeed-docs-1.0 branch.

Version(s):

Issue: https://issues.redhat.com/browse/OLS-2046

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 28, 2025

@openshift-ci-robot
Copy link

@rh-tokeefe: No Jira issue with key OLS-20245 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0

PR must be CP'd back to the lightspeed-docs-1.0 branch.

Version(s):

Issue: https://issues.redhat.com/browse/OLS-2046

Link to docs preview:
https://98222--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/troubleshoot/ols-troubleshooting-openshift-lightspeed.html#ols-thinking-model-generates-delineator-prompt_ols-troubleshooting-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@thoraxe thoraxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes requested


The {ols-long} Service does not configure the delineator behavior or produce the delineators in the output. The delineator feature is a model configuration setting. Typically, you can disable the feature using one of the following methods:

* Append your question prompt with the specific keyword that the model requires to toggle the delineator feature off. For example, `/nothink`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to specify that this is dependent on the model and the model's documentation should indicate if this works or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

The {ols-long} Service does not configure the delineator behavior or produce the delineators in the output. The delineator feature is a model configuration setting. Typically, you can disable the feature using one of the following methods:

* Append your question prompt with the specific keyword that the model requires to toggle the delineator feature off. For example, `/nothink`.
* Use API configuration settings in the model to turn the delineator feature off No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reworded to say that the inference server configuration may need to be modified to disable this, and that would be in the docs for the inference server and/or the model.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rh-tokeefe rh-tokeefe changed the title OLS-20245: Inform user about expected prompt output on OLS when using… OLS-2045: Inform user about expected prompt output on OLS when using… Sep 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025

@rh-tokeefe: This pull request references OLS-2045 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0

PR must be CP'd back to the lightspeed-docs-1.0 branch.

Version(s):

Issue: https://issues.redhat.com/browse/OLS-2046

Link to docs preview:
https://98222--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/troubleshoot/ols-troubleshooting-openshift-lightspeed.html#ols-thinking-model-generates-delineator-prompt_ols-troubleshooting-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoaoFula
Copy link
Contributor

JoaoFula commented Sep 5, 2025

LGTM

@rh-tokeefe rh-tokeefe force-pushed the OLS-2045 branch 3 times, most recently from 05d4b9f to 03f8748 Compare September 5, 2025 17:57
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - very minor comment


The {ols-long} Service does not configure the delineator behavior or produce the delineators in the output. The delineator feature is a model configuration setting. Typically, you can disable the feature using one of the following methods:

* Append your question prompt with the specific keyword that the model requires to disable the delineator feature. For example, `/nothink`. For more information, see the documentation for the model you are using.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable the delineator feature, for example,

Maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

openshift-ci bot commented Sep 9, 2025

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-tokeefe rh-tokeefe merged commit ca37a71 into openshift:lightspeed-docs-main Sep 9, 2025
2 checks passed
@rh-tokeefe
Copy link
Contributor Author

/cherrypick lightspeed-docs-1.0

@openshift-cherrypick-robot

@rh-tokeefe: new pull request created: #98734

In response to this:

/cherrypick lightspeed-docs-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants