Skip to content

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Aug 31, 2025

Version(s):

gitops-docs-1.18

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6449

Link to docs preview:

Using Progressive Sync in OpenShift GitOps

QE review:

  • QE has approved this change.

SME review: atali@redhat.com
QE review: @varshab1210
Peer review:

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 31, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6449 which is a valid jira issue.

In response to this:

Version(s):

gitops-docs-1.18

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6449

Link to docs preview:

QE review:

  • QE has approved this change.

SME review:
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 31, 2025

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-6449 branch 2 times, most recently from 90b551f to 1b7d62e Compare August 31, 2025 12:12
@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 1, 2025

/retest

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 1, 2025

/retest-required

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-6449 branch 2 times, most recently from 96ac556 to 014d597 Compare September 2, 2025 05:19
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6449 which is a valid jira issue.

In response to this:

Version(s):

gitops-docs-1.18

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6449

Link to docs preview:

Using Progressive Sync in OpenShift GitOps

QE review:

  • QE has approved this change.

SME review:
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6449 which is a valid jira issue.

In response to this:

Version(s):

gitops-docs-1.18

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6449

Link to docs preview:

Using Progressive Sync in OpenShift GitOps

QE review:

  • QE has approved this change.

SME review: atali@redhat.com
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated my comments

Copy link

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varshab1210
Copy link

LGTM, thanks

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-6449 branch 2 times, most recently from b540e6d to bfef928 Compare September 16, 2025 06:19
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6449 which is a valid jira issue.

In response to this:

Version(s):

gitops-docs-1.18

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6449

Link to docs preview:

Using Progressive Sync in OpenShift GitOps

QE review:

  • QE has approved this change.

SME review: atali@redhat.com
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aali309
Copy link

aali309 commented Sep 16, 2025

Thanks @Dhruv-Soni11, LGTM!

Copy link

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a quick case correction suggested above.

Incorporating SME review comments

Adding QE and SME feedback

Incorporating additional SME review comments
Copy link

openshift-ci bot commented Sep 17, 2025

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this look good to me, a few minor suggestions, but it all depends on whether we are allowed to publish about alpha-quality s/w

* You have logged in to the {OCP} cluster as an administrator.
* You have installed the {gitops-shortname} Operator on your {OCP} cluster.
* You can access the default Argo CD instance in the `openshift-gitops` namespace.
* You have created an Argo CD ApplicationSet in your defined namespace, for example, `openshift-gitops`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* You have created an Argo CD ApplicationSet in your defined namespace, for example, `openshift-gitops`.
* You have created an Argo CD `ApplicationSet` resource/controller in your defined namespace, for example, `openshift-gitops`.


[IMPORTANT]
====
This is an experimental, alpha-quality feature. It allows you to control the order in which the `ApplicationSet` controller creates or updates the Applications owned by an `ApplicationSet` resource. The feature might be removed in future releases or changed in a non-backwards-compatible way. For more information, see the upstream documentation for link:https://github.com/argoproj/argoproj/blob/main/community/feature-status.md#alpha[Feature Status in Argo Projects (Github docs)].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a decision here from DPM/CS over whether we can publish alpha-quality s/w, due to support considerations. Is this dev preview or tech preview?

* You have installed the {gitops-shortname} Operator on your {OCP} cluster.
* You can access the default Argo CD instance in the `openshift-gitops` namespace.
* You have created an Argo CD ApplicationSet in your defined namespace, for example, `openshift-gitops`.
* You have created a few Argo CD applications using an Argo CD ApplicationSet, which is defined in your namespace, for example, `openshift-gitops`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above for ApplicationSet


.Procedure

. Set the `RollingSync` parameter for the `applicationSet` spec. The following example contains a sample YAML configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Set the `RollingSync` parameter for the `applicationSet` spec. The following example contains a sample YAML configuration.
. Set the `RollingSync` parameter for the `ApplicationSet` spec. The following example contains a sample YAML configuration.

namespace: guestbook-{{.env}}
----

. Apply the YAML file by running the following command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Apply the YAML file by running the following command.
. Apply the YAML file by running the following command:


If the **Progressive Sync** section is missing from the Application details:

* Confirm that the application is managed by an `ApplicationSet` with the `RollingSync` strategy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Confirm that the application is managed by an `ApplicationSet` with the `RollingSync` strategy.
* Confirm that the application is managed by an `ApplicationSet` controller with the `RollingSync` strategy.


:_mod-docs-content-type: PROCEDURE
[id="gitops-adding-extraCommandArgs-to-argo-cd_{context}"]
= Adding the 'extraCommandArgs' argument to the Argo CD CR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are meant to be ticks indicating code, instead of single quotes - 'extraCommandArgs'

But again I don't think we are allowed to have styled content in titles, according to style guide, so maybe just leave plain

@gabriel-rh
Copy link
Contributor

OCP docs has a strict policy of not documenting dev preview content , only tech preview.

It may be possible for a Content Strategist or DPM to get an exception to this rule, but this probably needs the approval of the support team.

More information available here: https://redhat-documentation.github.io/supplementary-style-guide/#developer-preview-guidance

Some products, such as Red Hat Openshift Container Platform, do not include Developer Preview content in the documentation. Check with your Content Strategist or Support contact to confirm whether you can publish Developer Preview documentation for your product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants