Skip to content

PR for SRVLOGIC-537: Add "Configuring custom Maven mirrors" section in the OpenShift Serverless Logic docs #98413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

PR for SRVLOGIC-537: Add "Configuring custom Maven mirrors" section in the OpenShift Serverless Logic docs #98413

merged 1 commit into from
Sep 10, 2025

Conversation

kaldesai
Copy link

@kaldesai kaldesai commented Sep 3, 2025 •
edited
Loading

Affected versions:

  • serverless-docs-1.37
  • serverless-docs-1.36
  • serverless-docs-1.35

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-537

Doc preview: Configuring custom Maven mirrors

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2025 •
edited by openshift-ci bot
Loading

@kaldesai: This pull request references SRVLOGIC-537 which is a valid jira issue.

In response to this:

Affected versions: serverless-docs-1.37

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-537

Doc preview: Configuring custom Maven mirrors

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kaldesai
Copy link
Author

kaldesai commented Sep 3, 2025

/label serverless

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. serverless Label for all Serverless PRs labels Sep 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2025 •
edited by openshift-ci bot
Loading

@kaldesai: This pull request references SRVLOGIC-537 which is a valid jira issue.

In response to this:

Affected versions:

  • serverless-docs-1.37
  • serverless-docs-1.36
  • serverless-docs-1.35

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-537

Doc preview: Configuring custom Maven mirrors

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 3, 2025 •
edited
Loading

🤖 Wed Sep 10 10:41:50 - Prow CI generated the docs preview:

https://98413--ocpdocs-pr.netlify.app/openshift-serverless/latest/serverless-logic/serverless-logic-configuring-custom-maven-mirrors.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2025 •
edited by openshift-ci bot
Loading

@kaldesai: This pull request references SRVLOGIC-537 which is a valid jira issue.

In response to this:

Affected versions:

  • serverless-docs-1.37
  • serverless-docs-1.36
  • serverless-docs-1.35

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-537

Doc preview: Configuring custom Maven mirrors

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kaldesai
Copy link
Author

kaldesai commented Sep 3, 2025

@briandooley FYI

ricardozanini
ricardozanini suggested changes Sep 3, 2025
View reviewed changes
@ricardozanini
Copy link

@wmedvede can you please take a look?

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 9, 2025 •
edited by openshift-ci bot
Loading

@kaldesai: This pull request references SRVLOGIC-537 which is a valid jira issue.

In response to this:

Affected versions:

  • serverless-docs-1.37
  • serverless-docs-1.36
  • serverless-docs-1.35

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-537

Doc preview: Configuring custom Maven mirrors

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 9, 2025 •
edited by openshift-ci bot
Loading

@kaldesai: This pull request references SRVLOGIC-537 which is a valid jira issue.

In response to this:

Affected versions:

  • serverless-docs-1.37
  • serverless-docs-1.36
  • serverless-docs-1.35

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-537

Doc preview: Configuring custom Maven mirrors

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gabriel-rh
gabriel-rh approved these changes Sep 9, 2025
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only a few tiny suggestions

just remember to squash commits

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2025 •
edited by openshift-ci bot
Loading

@kaldesai: This pull request references SRVLOGIC-537 which is a valid jira issue.

In response to this:

Affected versions:

  • serverless-docs-1.37
  • serverless-docs-1.36
  • serverless-docs-1.35

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-537

Doc preview: Configuring custom Maven mirrors

Reviews:

  • QE has approved this change.
  • SME has approved this change.
  • Peer has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kaldesai kaldesai force-pushed the SRVLOGIC-537-maven-mirrors branch from 14da713 to 024856d Compare September 10, 2025 06:46
briandooley
briandooley requested changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@briandooley briandooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@kaldesai kaldesai force-pushed the SRVLOGIC-537-maven-mirrors branch from 57cfea4 to 26a53f8 Compare September 10, 2025 08:22
@kaldesai
Copy link
Author

@briandooley I have fixed that typo, and this PR is now ready to merge. Thank you!

briandooley
briandooley requested changes Sep 10, 2025
View reviewed changes
@kaldesai kaldesai force-pushed the SRVLOGIC-537-maven-mirrors branch from e3c0a32 to b4c409d Compare September 10, 2025 10:34
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 10, 2025

@kaldesai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@briandooley briandooley merged commit 34e86fa into openshift:serverless-docs-main Sep 10, 2025
2 checks passed
@briandooley
Copy link
Contributor

/cherrypick serverless-docs-1.35

@briandooley
Copy link
Contributor

/cherrypick serverless-docs-1.36

@briandooley
Copy link
Contributor

/cherrypick serverless-docs-1.37

@openshift-cherrypick-robot
Copy link

@briandooley: new pull request created: #98799

In response to this:

/cherrypick serverless-docs-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 10, 2025
Merged
@openshift-cherrypick-robot
Copy link

@briandooley: new pull request created: #98800

In response to this:

/cherrypick serverless-docs-1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 10, 2025
Merged
@openshift-cherrypick-robot
Copy link

@briandooley: new pull request created: #98801

In response to this:

/cherrypick serverless-docs-1.37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandooley briandooley briandooley requested changes

@gabriel-rh gabriel-rh gabriel-rh approved these changes

+2 more reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@jakubschwan jakubschwan jakubschwan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. serverless Label for all Serverless PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kaldesai @openshift-ci-robot @ocpdocs-previewbot @ricardozanini @briandooley @openshift-cherrypick-robot @jakubschwan @gabriel-rh