OSDOCS-16038 created assemblies and modules for egress proxy info #98461

wgabor0427 · 2025-09-03T15:44:58Z

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/OSDOCS-16038

Link to docs preview:
https://98461--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/external_secrets_operator/external-secrets-operator-proxy.html

QE review:

QE has approved this change.

Additional information:

ocpdocs-previewbot · 2025-09-03T15:57:33Z

🤖 Mon Oct 13 15:42:00 - Prow CI generated the docs preview:

https://98461--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/external_secrets_operator/external-secrets-operator-install.html
https://98461--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/external_secrets_operator/external-secrets-operator-proxy.html
https://98461--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/external_secrets_operator/external-secrets-operator-release-notes.html
https://98461--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/external_secrets_operator/external-secrets-operator-uninstall.html
https://98461--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/external_secrets_operator/index.html

bharath-b-rh

@wgabor0427 Thank you for the doc udpates.

For ESO we will need to document on configuring the proxy parameters http_proxy, https_proxy and noproxy, but ESO doesn't have trust bundle related use case. Let me share a draft on the required content.

wgabor0427 · 2025-09-22T18:35:31Z

@bharath-b-rh I was wondering if you had a draft of the required content yet. Thanks.

bharath-b-rh · 2025-10-06T06:20:30Z

security/external_secrets_operator/external-secrets-operator-proxy.adoc

+
+
+// Proxy security considerations
+include::modules/external-secrets-proxy-security-considerations.adoc[leveloffset=+2]


We need to add it as a sub-section under 11.1. External Secrets Operator for Red Hat OpenShift overview

bharath-b-rh

/lgtm

except for couple of nits. Thank you!

bharath-b-rh · 2025-10-09T04:25:53Z

security/external_secrets_operator/index.adoc

 * xref:../../installing/overview/installing-fips.adoc#installing-fips-mode_installing-fips[Installing a cluster in FIPS mode]
 * xref:../../installing/overview/installing-preparing.adoc#installing-preparing-security[Do you need extra security for your cluster?]
+
+// Proxy security considerations


Security considerations are applicable to the product in general, maybe we need to update it to below or something similar.

Suggested change

// Proxy security considerations

// Product security considerations

bharath-b-rh · 2025-10-09T04:26:09Z

modules/external-secrets-proxy-security-considerations.adoc

+
+:_mod-docs-content-type: REFERENCE
+[id="external-secrets-proxy-security-considerations_{context}"]
+= Security considerations when using the egress proxy


Suggested change

= Security considerations when using the egress proxy

= Security Considerations

Maybe say "Security considerations"

bharath-b-rh · 2025-10-09T13:12:17Z

/lgtm

wgabor0427 · 2025-10-10T20:08:05Z

/label merge-review-needed

bscott-rh

Generally looks good, but there is a procedure that needs to be slightly reworked for DITA compliance. Also one suggestion - if those features are going GA, you may as well delete the tech preview lines rather than just commenting them out. Up to you.

bscott-rh · 2025-10-13T15:02:18Z

modules/external-secrets-proxy-support.adoc

+<2> Proxy URL for the https requests.
+<3> Comma-separated list of hostnames and/or CIDRs and/or IPs for which the proxy should not be used.
+
+To set the proxy in the `ExternalSecretsManager` resource, perform the following steps.


It looks like there are two separate procedures contained in a single procedure module, which is not allowed from a DITA migration perspective. You can either break this into two separate procedure modules, or turn it into a "compound procedure" by doing something like this:

* To set the proxy in the `ExternalSecretsConfig` resource, perform the following steps: .. step 1 .. step 2 * To set the proxy in the `ExternalSecretsManager` resource, perform the following steps: .. step 1 .. step 2

or you can generalize the procedure so that one procedure covers both cases, like this:

. Edit the custom resource you want to use by running the following command: + [source,terminal] ---- $ oc edit <cr_name> cluster ---- + etc

Put it into a "compound procedure"

openshift-ci · 2025-10-13T15:24:33Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2025-10-13T15:43:04Z

@wgabor0427: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bscott-rh

Merge review LGTM.

bscott-rh · 2025-10-13T16:05:11Z

/cherrypick enterprise-4.20

openshift-cherrypick-robot · 2025-10-13T16:06:06Z

@bscott-rh: new pull request created: #100405

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 3, 2025

bharath-b-rh reviewed Sep 17, 2025

View reviewed changes

wgabor0427 force-pushed the OSDOCS-16038 branch 2 times, most recently from f46e2ef to 5d8dc83 Compare September 30, 2025 14:15

wgabor0427 force-pushed the OSDOCS-16038 branch 7 times, most recently from 3eae74a to dd64ea6 Compare October 2, 2025 21:04

bharath-b-rh reviewed Oct 6, 2025

View reviewed changes

wgabor0427 force-pushed the OSDOCS-16038 branch 2 times, most recently from 9c8af29 to fd11cc1 Compare October 7, 2025 18:46

bharath-b-rh reviewed Oct 9, 2025

View reviewed changes

openshift-ci bot assigned bharath-b-rh Oct 9, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025

wgabor0427 force-pushed the OSDOCS-16038 branch from fd11cc1 to cd57721 Compare October 9, 2025 12:24

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025

bharath-b-rh approved these changes Oct 9, 2025

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 10, 2025

bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 13, 2025

bscott-rh reviewed Oct 13, 2025

View reviewed changes

wgabor0427 force-pushed the OSDOCS-16038 branch from cd57721 to 9fb4e96 Compare October 13, 2025 15:24

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025

OSDOCS-16038 removed TP message

53668b5

wgabor0427 force-pushed the OSDOCS-16038 branch from 9fb4e96 to 53668b5 Compare October 13, 2025 15:26

bscott-rh approved these changes Oct 13, 2025

View reviewed changes

bscott-rh added branch/enterprise-4.20 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Oct 13, 2025

bscott-rh added this to the Planned for 4.20 GA milestone Oct 13, 2025

bscott-rh merged commit b65ceae into openshift:main Oct 13, 2025
2 checks passed

openshift-cherrypick-robot mentioned this pull request Oct 13, 2025

[enterprise-4.20] OSDOCS-16038 created assemblies and modules for egress proxy info #100405

Merged



		// Proxy security considerations
		include::modules/external-secrets-proxy-security-considerations.adoc[leveloffset=+2]

	// Proxy security considerations
	// Product security considerations

	= Security considerations when using the egress proxy
	= Security Considerations

OSDOCS-16038 created assemblies and modules for egress proxy info #98461

OSDOCS-16038 created assemblies and modules for egress proxy info #98461

Conversation

wgabor0427 commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bharath-b-rh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wgabor0427 commented Sep 22, 2025

Uh oh!

bharath-b-rh Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

bharath-b-rh left a comment

Choose a reason for hiding this comment

Uh oh!

bharath-b-rh Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

bharath-b-rh Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

wgabor0427 Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

bharath-b-rh commented Oct 9, 2025

Uh oh!

wgabor0427 commented Oct 10, 2025

Uh oh!

bscott-rh left a comment

Choose a reason for hiding this comment

Uh oh!

bscott-rh Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

wgabor0427 Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

bscott-rh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bscott-rh commented Oct 13, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wgabor0427 commented Sep 3, 2025 •

edited

Loading

ocpdocs-previewbot commented Sep 3, 2025 •

edited

Loading

bharath-b-rh left a comment •

edited

Loading