OSDOCS-16222: Cluster API AWS capacityReservationPreference #99344
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jeana-redhat: This pull request references OSDOCS-16222 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@jeana-redhat: This pull request references OSDOCS-16222 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/S
|
@jeana-redhat: This pull request references OSDOCS-16222 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@BraeTroutman and @huali9 PTAL 🙇 |
|
🤖 Mon Sep 22 14:24:51 - Prow CI generated the docs preview: |
|
@jeana-redhat same points as Huali from my end re: using PascalCase rather than kebab case for the preference enum values. Otherwise looks great to me! |
jeana-redhat
force-pushed
the
OSDOCS-16222-capi-aws-CapacityReservationPreference
branch
from
b72987f to
5aafddc
Compare
|
@jeana-redhat: This pull request references OSDOCS-16222 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jeana-redhat
added
the
merge-review-needed
|
@jeana-redhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thank you @jeana-redhat |
|
/label merge-review-in-progress |
openshift-ci
bot
added
the
merge-review-in-progress
bergerhoffer
added
ok-to-merge
and removed
merge-review-in-progress
|
/cherrypick enterprise-4.20 |
|
@jeana-redhat: new pull request created: #99576 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Version(s):
4.20+
Issue:
OSDOCS-16222
Link to docs preview:
Capacity Reservation configuration options
QE review:
Additional information: