Skip to content

CMA Update token example #99478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

CMA Update token example #99478

merged 1 commit into from
Sep 22, 2025

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Sep 22, 2025 •
edited
Loading

Updated example bearer token in response to InfoSec concern emailed to @dfitzmau

Cherrypick after #99294 is fully cherrypicked. This PR depends on a change in that PR.

@mburke5678 mburke5678 added this to the Continuous Release milestone Sep 22, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2025
@mburke5678 mburke5678 mentioned this pull request Sep 22, 2025
Closed
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 22, 2025 •
edited
Loading

🤖 Mon Sep 22 15:58:54 - Prow CI generated the docs preview:

https://99478--ocpdocs-pr.netlify.app/openshift-dedicated/latest/nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.html
https://99478--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.html
https://99478--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.html
https://99478--ocpdocs-pr.netlify.app/openshift-rosa/latest/nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.html

dfitzmau
dfitzmau reviewed Sep 22, 2025
View reviewed changes
nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.adoc Outdated
namespace: my-namespace
data:
bearerToken: "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXV" <1>
bearerToken: "dG9rZW4=..." <1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this PR, @mburke5678 . I'm unsure if this example will still generate the security alert message. How about the following value?

<bearer_token>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfitzmau A boring, but safe option (dG9rZW4= is token in base64, tee-hee). Done.

@mburke5678 mburke5678 force-pushed the cma-change-token-example branch from a3d419d to f3d0b0e Compare September 22, 2025 15:49
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 22, 2025

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Contributor

Thanks, @mburke5678 . LGTM. Please merge the PR to the appropriate branches.

@mburke5678 mburke5678 merged commit 18353b5 into openshift:main Sep 22, 2025
2 checks passed
@mburke5678 mburke5678 deleted the cma-change-token-example branch September 22, 2025 19:52
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #99731

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 25, 2025
Merged
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.13

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.14

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.15

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.16

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.17

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.18

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.19

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #99732

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 25, 2025
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #99733

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 25, 2025
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #99734

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 25, 2025
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #99735

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 25, 2025
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: #99478 failed to apply on top of branch "enterprise-4.17":

Applying: CMA Update token example
Using index info to reconstruct a base tree...
M	nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.adoc
Falling back to patching base and 3-way merge...
Auto-merging nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.adoc
CONFLICT (content): Merge conflict in nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CMA Update token example

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #99736

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 25, 2025
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #99737

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 25, 2025
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: #99478 failed to apply on top of branch "enterprise-4.20":

Applying: CMA Update token example
Using index info to reconstruct a base tree...
M	nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.adoc
Falling back to patching base and 3-way merge...
Auto-merging nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.adoc
CONFLICT (content): Merge conflict in nodes/cma/nodes-cma-autoscaling-custom-trigger-auth.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CMA Update token example

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mburke5678 mburke5678 mentioned this pull request Sep 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfitzmau dfitzmau dfitzmau left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
4 participants
@mburke5678 @ocpdocs-previewbot @dfitzmau @openshift-cherrypick-robot