Skip to content

CNV-46346: Adding docs for controller revisions #99504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

CNV-46346: Adding docs for controller revisions #99504

merged 1 commit into from
Oct 8, 2025

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Sep 22, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 22, 2025 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references CNV-46346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/CNV-46346

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 22, 2025 •
edited
Loading

🤖 Wed Oct 08 19:57:12 - Prow CI generated the docs preview:

https://99504--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/creating_vm/virt-creating-vms-from-instance-types.html
https://99504--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html
https://99504--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-primary-udn.html
https://99504--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/creating_vm/virt-creating-vms-from-instance-types.html
https://99504--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/managing_vms/virt-edit-vms.html
https://99504--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/vm_networking/virt-connecting-vm-to-primary-udn.html
https://99504--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/creating_vm/virt-creating-vms-from-instance-types.html
https://99504--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/managing_vms/virt-edit-vms.html
https://99504--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/vm_networking/virt-connecting-vm-to-primary-udn.html

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2025
@abrennan89 abrennan89 requested a review from lyarwood September 29, 2025 13:54
lyarwood
lyarwood reviewed Sep 29, 2025
View reviewed changes
Copy link

@lyarwood lyarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay!

@abrennan89 abrennan89 force-pushed the CNV-46346 branch 2 times, most recently from 68f5a87 to ac32f97 Compare September 30, 2025 18:42
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2025
@abrennan89 abrennan89 added this to the Continuous Release milestone Sep 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 30, 2025 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references CNV-46346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/CNV-46346

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lyarwood
lyarwood reviewed Oct 1, 2025
View reviewed changes
Copy link

@lyarwood lyarwood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick nit, the reference to the ControllerRevision` is now in the status of the VM. Otherwisee this LGTM!

@abrennan89 abrennan89 force-pushed the CNV-46346 branch 2 times, most recently from 82bf0d0 to f1ad451 Compare October 1, 2025 15:03
@abrennan89 abrennan89 changed the title [WIP] CNV-46346: Adding docs for controller revisions CNV-46346: Adding docs for controller revisions Oct 1, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2025
geetikakay
geetikakay reviewed Oct 6, 2025
View reviewed changes
@abrennan89 abrennan89 force-pushed the CNV-46346 branch 2 times, most recently from 6c65424 to 6fef805 Compare October 6, 2025 16:12
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2025 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references CNV-46346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/CNV-46346

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

geetikakay
geetikakay reviewed Oct 6, 2025
View reviewed changes
@abrennan89 abrennan89 force-pushed the CNV-46346 branch 2 times, most recently from 0c1b4d1 to 31b27f6 Compare October 6, 2025 17:04
@geetikakay
Copy link

Lgtm

jherrman
jherrman reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@jherrman jherrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid overall, but added a couple of comments and suggestions for your consideration.

@abrennan89 abrennan89 force-pushed the CNV-46346 branch 2 times, most recently from 818e2c0 to f46384d Compare October 7, 2025 16:43
@abrennan89
Copy link
Contributor Author

@geetikakay @lyarwood per @jherrman 's comment I have added some additional context information about why a user might want to change the VM type. Can you please take another look and confirm if this is accurate or needs updates?
Many thanks!

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Oct 7, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Oct 7, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Oct 7, 2025
View reviewed changes
lyarwood
lyarwood reviewed Oct 8, 2025
View reviewed changes
@abrennan89 abrennan89 force-pushed the CNV-46346 branch 2 times, most recently from 8654cae to 523458b Compare October 8, 2025 13:17
lyarwood
lyarwood approved these changes Oct 8, 2025
View reviewed changes
Copy link

@lyarwood lyarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

jherrman
jherrman reviewed Oct 8, 2025
View reviewed changes
@abrennan89 abrennan89 force-pushed the CNV-46346 branch 2 times, most recently from 4408657 to f703804 Compare October 8, 2025 19:29
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 8, 2025

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@abrennan89 abrennan89 merged commit b240287 into openshift:main Oct 8, 2025
2 checks passed
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.19

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #100224

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 8, 2025
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #100225

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@jherrman jherrman jherrman left review comments

@geetikakay geetikakay geetikakay left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@lyarwood lyarwood lyarwood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.19 branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

8 participants

@abrennan89 @openshift-ci-robot @ocpdocs-previewbot @geetikakay @openshift-cherrypick-robot @lyarwood @jherrman @ocpdocs-vale-bot